[17.0][OCA-PORT] sale_timesheet_line_exclude from 16.0 to 17.0 pr #707 #718 #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't copy the field by default, because it breaks the OE timesheet grid for users in the security group that hides the field. Functionally, it also makes sens to not copy this field, because it is better to consider the new line not excluded by default.
…clude flag While the test does not reveal this, without this change, clicking on the checkbox in the timesheet list view does not reset the so line.
sbidoul
changed the title
CRogos
reviewed
Feb 8, 2025
| <field name="category_id" ref="base.module_category_hidden" /> | ||
| <field | ||
| name="comment" | ||
| >Gives access to the Non-Billable field on timesheets.</field> |
There was a problem hiding this comment.
Maybe the role should also be added automatically to the Admin account?
<field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
Yes, this was mentioned on the original PR #707
Maybe? This should be in a distinct PR, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.