Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] web_widget_numeric_step: always display on touch screens; avoid layout jumping otherwise #2694

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[FIX] web_widget_numeric_step: always display on touch screens; avoid layout jumping otherwise #2694

merged 1 commit into from
Dec 14, 2023

Conversation

yajo
Copy link
Member

@yajo yajo commented Dec 14, 2023

Before this patch:

  • On a tablet, buttons wouldn't display (big screen; can't hover).

  • On a PC, fields would make layout jumps while hovering.

    Before:

    before.webm.mp4

    After:

    after.webm.mp4

@moduon MT-4472

@yajo
[FIX] web_widget_numeric_step: always display on touch screens; avoid…
b6ca76d 
… layout jumping otherwise

Before this patch:
- On a tablet, buttons wouldn't display (big screen; can't hover).
- On a PC, fields would make layout jumps while hovering.

@moduon MT-4472
@yajo yajo force-pushed the 16.0-web_widget_numeric_step-always_display_mobile branch from ffdf7ed to b6ca76d Compare December 14, 2023 12:49
yajo added a commit to moduon/sale-workflow that referenced this pull request Dec 14, 2023
@yajo
[ADD] sale_numeric_step: new module for better selling on touch screens
b9ccc5b 
Together with OCA/web#2694, this will improve a lot the sell process while using tablets or phones.

@moduon MT-4472
@yajo yajo mentioned this pull request Dec 14, 2023
Merged
@yajo yajo self-assigned this Dec 14, 2023
@yajo yajo added this to the 16.0 milestone Dec 14, 2023
fcvalgar
fcvalgar approved these changes Dec 14, 2023
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,. thank you @yajo

rafaelbn
rafaelbn approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Thank you!

@yajo
Copy link
Member Author

yajo commented Dec 14, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2694-by-yajo-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9258758 into OCA:16.0 Dec 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cb5fd37. Thanks a lot for contributing to OCA. ❤️

@sergio-teruel
Copy link
Contributor

Why adopt de module??

@rafaelbn
Copy link
Member

Hello @sergio-teruel , we add our selves because we will maintain the module. Original author @quentinDupont or other contributors can add it selves as maintainers in a simple PR but module actually don't have any maintainer defined.

The OCA must grow in contributors and neither maintain nor decrease. The modules require more maintainers. You can discuss it here too OCA/maintainer-tools#592

@Shide Shide deleted the 16.0-web_widget_numeric_step-always_display_mobile branch December 15, 2023 06:45
@quentinDupont
Copy link
Contributor

Hi there!
For your information, I haven't started working on version 16 yet + I don't feel comfortable enough with JS code to be the main maintainer, as the code has been greatly improved by people other than myself ;)
thanks for keeping this module alive, excellent additions with this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

Assignees

@yajo yajo

Labels
approved bug merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yajo @OCA-git-bot @sergio-teruel @rafaelbn @quentinDupont @fcvalgar