Skip to content

workspace.save_image_file: set dpi on image.save, #343 #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

workspace.save_image_file: set dpi on image.save, #343 #611

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcb3503
workspace.save_image_file: set dpi on image.save, #343
kba Sep 21, 2020
552a7c9
dpi on save_image_file: reorder args, account for resolutionUnit == "cm"
kba Sep 22, 2020
666194a
Merge branch 'master' into dpi-save-image
kba Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ocrd/ocrd/workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,7 @@ def image_from_segment(self, segment, parent_image, parent_coords,
def save_image_file(self, image,
file_id,
file_grp,
dpi=None,
page_id=None,
mimetype='image/png',
force=False):
Expand All @@ -851,7 +852,15 @@ def save_image_file(self, image,
if not force and self.overwrite_mode:
force = True
image_bytes = io.BytesIO()
image.save(image_bytes, format=MIME_TO_PIL[mimetype])
if dpi and not isinstance(dpi, tuple):
dpi = (dpi, dpi)
elif not dpi:
# TODO - brittle, will this always find the original image?
orig_img_file = self.mets.find_files(pageId=page_id, mimetype='//^image')[0]
Copy link
Collaborator

@bertsky bertsky Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must adapt for the generator now, I believe.

Suggested change
orig_img_file = self.mets.find_files(pageId=page_id, mimetype='//^image')[0]
orig_img_file = next(self.mets.find_files(pageId=page_id, mimetype='//^image', local_only=True))

orig_img_pil = self.resolve_image_exif(orig_img_file.url)
exif = OcrdExif(orig_img_pil)
dpi = (exif.xResolution, exif.yResolution)
image.save(image_bytes, dpi=dpi, format=MIME_TO_PIL[mimetype])
file_path = str(Path(file_grp, '%s%s' % (file_id, MIME_TO_EXT[mimetype])))
out = self.add_file(
ID=file_id,
Expand Down