Fix CMake 4+ compatibility #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
Fix: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. | | | -- Configuring incomplete, errors occurred! Signed-off-by: Ilies CHERGUI <[email protected]>
ichergui
force-pushed
the
ichergui/fix-build-issues-pr
branch
from
8a643b1 to
9818d6d
Compare
kraj
reviewed
Aug 19, 2025
| +++ b/CMakeLists.txt | ||
| @@ -1,4 +1,4 @@ | ||
| -cmake_minimum_required(VERSION 3.1) | ||
| +cmake_minimum_required(VERSION 3.5) |
Contributor
There was a problem hiding this comment.
I think if its working, perhaps its worth letting upstream have a look at this patch.
| @@ -1,5 +1,5 @@ | ||
| # CMakeLists to build the cnmem library. | ||
| -cmake_minimum_required(VERSION 2.8.8) | ||
| +cmake_minimum_required(VERSION 3.5) |
Contributor
There was a problem hiding this comment.
Upstream seems to be dormant but it will be good to create a PR for it there as well.
| SRC_URI = " \ | ||
| git://github.com/dmlc/dlpack.git;protocol=https;branch=main;tag=v${PV} \ | ||
| file://0001-update-dlpack-project-version.patch \ | ||
| file://0002-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \ |
Contributor
There was a problem hiding this comment.
Lets backport dmlc/dlpack@5c210da from upstream instead.
| SRC_URI = " \ | ||
| git://github.com/jbeder/yaml-cpp.git;branch=master;protocol=https;tag=yaml-cpp-${PV} \ | ||
| file://0001-Updates-for-OE-cross-builds.patch \ | ||
| file://0002-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \ |
Contributor
There was a problem hiding this comment.
There is an upstream PR - jbeder/yaml-cpp#1358
bring that in here.
| SRC_URI = " \ | ||
| git://github.com/dcleblanc/SafeInt.git;protocol=https;nobranch=1;tag=${PV} \ | ||
| file://0001-Updates-for-OE-cross-builds.patch \ | ||
| file://0002-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \ |
Contributor
There was a problem hiding this comment.
backport - dcleblanc/SafeInt#39 this is already merged upstream
| +++ b/CMakeLists.txt | ||
| @@ -1,4 +1,4 @@ | ||
| -cmake_minimum_required (VERSION 2.8.12) | ||
| +cmake_minimum_required (VERSION 3.5) |
Contributor
There was a problem hiding this comment.
would be good to send a PR upstream for this
| file://0004-Use-native-protobuf-compiler.patch \ | ||
| file://0005-Disable-various-warnings.patch \ | ||
| file://0006-Fixups-for-cross-building-in-OE.patch \ | ||
| file://0007-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \ |
| SRC_URI = "\ | ||
| git://github.com/triton-inference-server/common.git;protocol=https;branch=r25.05 \ | ||
| file://0001-Build-fixups.patch \ | ||
| file://0002-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \ |
Contributor
There was a problem hiding this comment.
backporting - triton-inference-server/common@2e41435 would be nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those commits fixes the following issue: