Skip to content

fix: keep base package importable without ibis#30

Merged
azimov merged 1 commit intodevelopfrom
fix/base-import-without-ibis
Mar 20, 2026
Merged

fix: keep base package importable without ibis#30
azimov merged 1 commit intodevelopfrom
fix/base-import-without-ibis

Conversation

@egillax
Copy link
Collaborator

@egillax egillax commented Mar 20, 2026

@azimov ,

I just broke the nightly wheel build on develop. Because of importing stuff that needed ibis in api.py. I've fixed it in this and added a quick additional CI test that would expose this before merging PRs so this doesn't happen again.

@egillax egillax requested a review from azimov March 20, 2026 14:06
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.37%. Comparing base (0db6e37) to head (4d5d872).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
- Coverage    85.39%   85.37%   -0.02%     
===========================================
  Files          167      167              
  Lines        12379    12386       +7     
===========================================
+ Hits         10571    10575       +4     
- Misses        1808     1811       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@azimov azimov merged commit 252e68c into develop Mar 20, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants