reenable cdw test#2391
Open
p-hoffmann wants to merge 2 commits into
Open
Conversation
p-hoffmann
requested review from
LSriragavan,
brandantck,
jerome-ng,
khairul-syazwan,
maggie-li-yd and
satish-a0
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to re-enable the CDM configuration e2e test and relax blank-config generation in cdw-svc so it can run without an analytics service binding, while also simplifying cohort-definition aggregation in d2e-webapi.
Changes:
- Re-enabled the Playwright test for CDM configuration creation.
- Made
generateEmptyConfigtolerate missing analytics service credentials by falling back to an emptyvocabSchema. - Simplified
getCohortDefinitionListby removing several defensive fallbacks and parse guards around bookmarks, Atlas cohorts, and materialized cohort syntax.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/e2e/tests/17-configurations/CDM-creation.spec.ts |
Re-enables the long-running CDM configuration e2e scenario. |
plugins/functions/d2e-webapi/src/services/cohortdefinition.service.ts |
Changes how cohort definitions/bookmarks/materialized cohorts are fetched and parsed when building the combined list response. |
plugins/functions/cdw-svc/src/qe/config/configSuggestion.ts |
Adds a fallback path for generating an empty config when analytics connection parameters are unavailable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)