[Integrate-2475] Enable semantic search flow run for hana dataset#2670
Open
hengxian-jiang wants to merge 3 commits into
Open
[Integrate-2475] Enable semantic search flow run for hana dataset#2670hengxian-jiang wants to merge 3 commits into
hengxian-jiang wants to merge 3 commits into
Conversation
hengxian-jiang
requested review from
KangJingA,
SantanM,
p-hoffmann and
suwarnoong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Enables triggering the semantic search (search embedding) flow run for additional dataset types (incl. HANA OMOP) from the Admin Portal, while adding guardrails in both UI and jobplugins to prevent starting a run when required dataset-derived parameters are missing.
Changes:
- UI: Prevent semantic search setup from running when the dataset id is missing; disable the run button accordingly and add a localized error message.
- UI: Allow the “setup-semantic-search” action for additional dataset types via
ActionSelectorMap. - Jobplugins: Validate
databaseCodeandschemaNamederived from the dataset before starting the Prefect flow run.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/ui/apps/portal/src/plugins/SystemAdmin/StudyOverview/SetupSemanticSearchDialog/SetupSemanticSearchDialog.tsx | Adds dataset-id guard + disables submit while missing/while updating. |
| plugins/ui/apps/portal/src/contexts/app-context/states/translation-state.ts | Adds default (en) translation for the new “run error” message. |
| plugins/ui/apps/portal/src/constant.ts | Enables “setup-semantic-search” action for additional dataset types. |
| plugins/ui/apps/portal/public/translations/zh.json | Adds zh translation for the new “run error” message. |
| plugins/ui/apps/portal/public/translations/de.json | Adds de translation for the new “run error” message. |
| plugins/functions/jobplugins/src/utils/validateSearchEmbeddingParams.ts | Introduces shared validation for required dataset-derived params. |
| plugins/functions/jobplugins/src/controllers/SearchEmbeddingController.ts | Uses the new validation to reject invalid requests before launching the flow. |
suwarnoong
approved these changes
Jun 10, 2026
Zhimin-arya
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)