Add flow staging folder - #2920
Open
csafreen wants to merge 4 commits into
Open
Conversation
csafreen
marked this pull request as ready for review
July 22, 2026 02:04
csafreen
requested review from
SantanM,
brandantck,
p-hoffmann and
suwarnoong
as code owners
July 22, 2026 02:04
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a writable “flow staging” directory under /usr/src/data intended to be used as a shared bulk-load exchange location for Prefect flows, ensuring it exists with permissive permissions both in the image build and at Kubernetes runtime.
Changes:
- Create
/usr/src/data/flow_stagingduring the Trex image build and set it to mode1777(world-writable + sticky bit). - Ensure the same directory (and permissions) is created on the mounted PV via the Helm chart init container.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/trex/Dockerfile.v2 | Creates /usr/src/data/flow_staging in the image and sets sticky world-writable permissions. |
| charts/d2e-services/templates/d2e-deployment.yaml | Creates/chmods /usr/src/data/flow_staging at pod init time on the mounted volume. |
Zhimin-arya
approved these changes
Jul 23, 2026
SantanM
approved these changes
Jul 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
charts/d2e-services/templates/d2e-deployment.yaml:78
chmod 1777makes/usr/src/data/flow_stagingworld-writable on thetrex-volumePVC. That can be risky if multiple workloads/users can access this volume. Prefer least-privilege permissions via a dedicated GID + setgid directory (chmod 2770/2775) with appropriate podfsGroup/runAsGroup, or document why1777is necessary.
"mkdir -p /usr/src/data/plugins && mkdir -p /usr/src/data/cache && \
mkdir -p /usr/src/data/flow_staging && chmod 1777 /usr/src/data/flow_staging && \
cp -rfv /data/plugins/.npmrc /usr/src/data/plugins/.npmrc && \
services/trex/Dockerfile.v2:45
chmod 1777makes/usr/src/data/flow_stagingworld-writable. If this directory is on a shared PVC, any process with access could write/overwrite files there. Consider using a dedicated group (e.g.,chgrp+chmod 2770/2775with setgid) and settingfsGroup/runAsGroupin the pod, or document why1777is required.
# flow_staging: shared bulk-load exchange dir for Prefect flows with write access.
RUN mkdir -p /usr/src/data/cache /usr/src/data/plugins /usr/src/data/flow_staging /usr/src/cdw_data/built_in ./cert \
&& chmod 1777 /usr/src/data/flow_staging
Signed-off-by: Afreen <csafreen@gmail.com>
p-hoffmann
approved these changes
Aug 3, 2026
Signed-off-by: Afreen <csafreen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)