Fix drilldown prevalence by month sorting and trellis chart sorting in data characterization - #3024
Merged
Merged
Conversation
maggie-li-yd
requested review from
SantanM,
hengxian-jiang,
p-hoffmann and
suwarnoong
as code owners
July 31, 2026 03:08
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates chart ordering logic in the Portal’s drilldown chart components to improve readability and ensure categories/time-series appear in the expected order.
Changes:
- Sort trellis chart titles using natural (numeric-aware) ordering instead of pure lexicographic ordering.
- Sort “prevalence by month” chart X-axis data by
XCALENDARMONTHprior to formatting month labels.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/ui/apps/portal/src/components/Charts/Common/Drilldown/DrilldownTrellisChart/DrilldownTrellisChart.tsx | Switch trellis key sorting to numeric-aware collation for more intuitive panel ordering. |
| plugins/ui/apps/portal/src/components/Charts/Common/Drilldown/DrilldownPrevalenceByMonthChart/DrilldownPrevalenceByMonthChart.tsx | Introduce sorting by XCALENDARMONTH before generating X-axis labels for the month drilldown chart. |
5 tasks
suwarnoong
approved these changes
Jul 31, 2026
maggie-li-yd
force-pushed
the
maggie-li-yd/3023-dc-charts-sorting
branch
from
August 4, 2026 01:47
3772daf to
30f42ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Tim advised not to fill missing months with a prevalence of 0.
Before:
After:
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)