Fix Wizards card not growing - #3043
Merged
khairul-syazwan merged 1 commit intoAug 4, 2026
Merged
Conversation
khairul-syazwan
requested review from
LSriragavan,
brandantck,
jerome-ng,
maggie-li-yd and
p-hoffmann
as code owners
August 4, 2026 03:37
The portal's `.researcher__container main { flex: auto; min-height: 0 }` in
Researcher.scss also matches the Wizards app's own `<main class="content">`,
and outranks `.content` on specificity. The card therefore resolved to
`flex: 1 1 auto` with its automatic minimum size removed, so it shrank to the
available viewport height instead of its content height and tall wizard forms
spilled past the white background.
Raise the selector to `.shell > .content` so it beats the portal rule, and set
`flex-shrink: 0` so the card cannot be squeezed below its content. This matches
the fix already on develop (part of #2897), which never reached this branch.
Verified against this branch's source at 1440x900 with the portal researcher
rules applied: Calculate Incidence form spill 565px -> 0px.
khairul-syazwan
force-pushed
the
khairul-syazwan/fix-wizards-form-card-height-release-0.17
branch
from
August 4, 2026 03:57
e1a628a to
bfa0c1c
Compare
khairul-syazwan
deleted the
khairul-syazwan/fix-wizards-form-card-height-release-0.17
branch
August 4, 2026 06:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Wizards page the white card stops partway down a tall form. The fields below it — Diastolic Blood Pressure, Years, Conditions — and the
Back/Open cohortbuttons render on the grey page background.Reported on
release/v0.17.0-beta;developrenders correctly.Root cause
Two rules interact across the single-spa boundary.
plugins/ui/apps/portal/src/containers/researcher/Researcher.scsstargets the portal's own<main>with a descendant selector:WizardShell.tsxrenders the white card as<main class="content">nested inside that container, so the rule lands on it too. Themin-height: 0removes the flex automatic minimum size that would otherwise floor the card at its content height.release/v0.17.0-beta.content { flex: 1 }1 1 autodevelop.shell > .content { flex: 1 0 auto }1 0 auto.shellhasheight: calc(100vh - 56px), so the container height is definite and the card gets shrunk to fit it.Why develop is already fixed
The
.shell > .content { flex: 1 0 auto }line came from #2897 (5dda8a5c5), sub-commit "fix(wizards): grow form card with content".git branch -r --contains 5dda8a5c5lists onlydevelopand its merge-queue refs — no release branch. #2897 is a ~3,000-line feature PR (Shiny dashboard embedding, bookmark cache, MRI query comparator), so it was never back-ported. This PR ports just the layout line.Note for anyone who lands here from #2954: that commit is already on this branch, but it fixes the researcher dataset-information card — a structurally similar bug in a different file. It does not touch the Wizards app.
Change
plugins/ui/apps/wizards/src/components/WizardShell.module.css, one rule:.shell >outranks the portal rule;flex-shrink: 0keeps the card from being squeezed below its content once the min-height floor is gone.flex-grow: 1is retained so the card still fills the viewport when a wizard's content is short.<main class="content">is the only element in the wizards app the portal's descendant selector can match, so the change is scoped to this one rule. The otherflex: 1in the app (StepForm.module.css.groupInputs .input) is a horizontal row input and is unaffected.Verification
Measured on this branch's source at 1440x900,
Calculate Incidencewizard, with the portal's twoResearcher.scssrules applied. Those rules are byte-identical ondevelopand this branch, so the wizards app source is the only variable.develop1 0 auto1 1 auto1 0 autoThe before-fix run reproduces the reported screenshot exactly.
Test plan
Calculate Incidence) fully enclosed by the white background, including theBack/Open cohortrowflex-grow: 1retained)release/v0.17.0-betainstance with thewizardsfeature flag enabledVerification caveats
defaultEnabled: falseand the deployed trex plugin manifest carries no Wizards nav entry, so/researcher/wizardsredirects to/researcher/information.