fix websockets#155
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the runtime’s HTTP upgrade path so Node-compatible http server WebSocket upgrades can work when requests are served via trex-runtime’s op_http_start duplex-stream machinery (instead of upstream Deno.serve’s InnerRequest-based checks).
Changes:
- Adds a trex-runtime-specific
upgradeHttpRawimplementation that usesop_http_upgrade_raw2+ fence signaling, and wires it intointernals.upgradeHttpRaw. - Installs the override during
bootstrapSBEdge()to avoid non-deterministic extension module-load ordering issues. - Updates the Deno fork commit pins in
Cargo.lock.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ext/runtime/js/http.js | Implements and exports an installable upgradeHttpRaw override using trex-runtime’s raw-upgrade ops. |
| ext/runtime/js/bootstrap.js | Calls the installer during bootstrap to ensure the override wins over upstream initialization. |
| Cargo.lock | Updates git commit hashes for Deno-derived crates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.