Skip to content

fix websockets#155

Merged
p-hoffmann merged 1 commit into
developfrom
p-hoffmann/ws
May 9, 2026
Merged

fix websockets#155
p-hoffmann merged 1 commit into
developfrom
p-hoffmann/ws

Conversation

@p-hoffmann
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 9, 2026 05:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the runtime’s HTTP upgrade path so Node-compatible http server WebSocket upgrades can work when requests are served via trex-runtime’s op_http_start duplex-stream machinery (instead of upstream Deno.serve’s InnerRequest-based checks).

Changes:

  • Adds a trex-runtime-specific upgradeHttpRaw implementation that uses op_http_upgrade_raw2 + fence signaling, and wires it into internals.upgradeHttpRaw.
  • Installs the override during bootstrapSBEdge() to avoid non-deterministic extension module-load ordering issues.
  • Updates the Deno fork commit pins in Cargo.lock.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
ext/runtime/js/http.js Implements and exports an installable upgradeHttpRaw override using trex-runtime’s raw-upgrade ops.
ext/runtime/js/bootstrap.js Calls the installer during bootstrap to ensure the override wins over upstream initialization.
Cargo.lock Updates git commit hashes for Deno-derived crates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ext/runtime/js/http.js
@p-hoffmann p-hoffmann merged commit e822dbf into develop May 9, 2026
14 checks passed
@p-hoffmann p-hoffmann deleted the p-hoffmann/ws branch May 9, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants