Skip to content

fix clippy warnings#30

Merged
p-hoffmann merged 5 commits intodevelopfrom
p-hoffmann/rootpath
Oct 26, 2025
Merged

fix clippy warnings#30
p-hoffmann merged 5 commits intodevelopfrom
p-hoffmann/rootpath

Conversation

@p-hoffmann
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings October 26, 2025 09:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses clippy warnings by removing an unused variable and its sole usage. The change renames current_exe_name to _current_exe_name (suppressing the unused variable warning) and replaces its usage in a format string with a hardcoded value.

Key Changes

  • Renamed current_exe_name to _current_exe_name to indicate it's intentionally unused
  • Replaced dynamic executable name in temp directory path with hardcoded "sb-compile-trex"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/deno_facade/module_loader/standalone.rs
Comment thread crates/deno_facade/module_loader/standalone.rs Outdated
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 18816183413

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 37.433%

Files with Coverage Reduction New Missed Lines %
crates/base/src/worker/supervisor/strategy_per_request.rs 2 76.96%
deno/cache/cache_db.rs 2 69.18%
Totals Coverage Status
Change from base Build 18816100372: -0.005%
Covered Lines: 14808
Relevant Lines: 39559

💛 - Coveralls

@p-hoffmann p-hoffmann changed the title fix clippy fix test Oct 26, 2025
@p-hoffmann p-hoffmann changed the title fix test fix clippy warning Oct 26, 2025
@p-hoffmann p-hoffmann changed the title fix clippy warning fix clippy warnings Oct 26, 2025
@p-hoffmann p-hoffmann merged commit 14964d4 into develop Oct 26, 2025
9 checks passed
@p-hoffmann p-hoffmann deleted the p-hoffmann/rootpath branch October 26, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants