Skip to content

check if rotateFromDirections exists before setting normal, origin, etc. in updatePaintbrush #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check if rotateFromDirections exists before setting normal, origin, etc. in updatePaintbrush #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4924162
check if rotateFromDirections exists before setting normal, origin, e…
tamaynard Dec 20, 2020
66d0bce
Merge branch 'master' into rotateFromDirectionsFix
swederik Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/VTKViewport/View2D.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,15 @@ export default class View2D extends Component {
}

updatePaintbrush() {
const manip = this.paintWidget.getManipulator();
const handle = this.paintWidget.getWidgetState().getHandle();
const camera = this.paintRenderer.getActiveCamera();
const normal = camera.getDirectionOfProjection();
manip.setNormal(...normal);
manip.setOrigin(...camera.getFocalPoint());
handle.rotateFromDirections(handle.getDirection(), normal);
if (typeof handle.rotateFromDirections === 'function') {
const manip = this.paintWidget.getManipulator();
const camera = this.paintRenderer.getActiveCamera();
const normal = camera.getDirectionOfProjection();
manip.setNormal(...normal);
manip.setOrigin(...camera.getFocalPoint());
handle.rotateFromDirections(handle.getDirection(), normal);
}
}

componentDidMount() {
Expand Down