Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
oda_readerpackage to version 1.3.5, focusing on making the dataflow version handling more robust and preventing crashes when URLs do not contain a version pattern. The changes ensure that the code gracefully handles edge cases during API version fallback logic.Improvements to dataflow version handling:
_get_dataflow_version()function now returnsNoneif no version pattern is found in the URL, instead of raising an exception. This prevents crashes when the URL does not include a version.get_data_from_api()now only attempts to fallback if a version is actually present in the URL, further improving robustness.Project metadata:
pyproject.tomlto reflect the new release.