optee_rust_examples_ext: use 'rust install toolchain' #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @b49020 |
|
Sounds like a better alternative as per rust-lang/rustup#2686 too. FWIW:
|
|
Thanks Sumit! |
Should I use your kernel.org address instead perhaps...? |
Invoke 'rust install toolchain' instead of relying on a side effect of 'cargo --version'. It looks like the side effect doesn't exist anymore. From optee_os CI: 2025-03-04T10:15:19.2947623Z Configuring OP-TEE rust examples 2025-03-04T10:15:19.3387454Z error: toolchain 'nightly-2023-12-18-x86_64-unknown-linux-gnu' is not installed 2025-03-04T10:15:19.3389280Z help: run `rustup toolchain install nightly-2023-12-18-x86_64-unknown-linux-gnu` to install it 2025-03-04T10:15:19.3403890Z make[2]: *** [package/pkg-generic.mk:273: /__w/optee_test/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/.stamp_configured] Error 1 2025-03-04T10:15:19.3405144Z make[2]: *** Waiting for unfinished jobs.... Signed-off-by: Jerome Forissier <[email protected]> Reviewed-by: Sumit Garg <[email protected]>
My Linaro email is still active for few days, so I am using that for reviews as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke 'rust install toolchain' instead of relying on a side effect of 'cargo --version'. It looks like the side effect doesn't exist anymore. From optee_os CI:
2025-03-04T10:15:19.2947623Z Configuring OP-TEE rust examples
2025-03-04T10:15:19.3387454Z error: toolchain 'nightly-2023-12-18-x86_64-unknown-linux-gnu' is not installed
2025-03-04T10:15:19.3389280Z help: run
rustup toolchain install nightly-2023-12-18-x86_64-unknown-linux-gnuto install it2025-03-04T10:15:19.3403890Z make[2]: *** [package/pkg-generic.mk:273: /__w/optee_test/optee_repo_qemu_v8/out-br/build/optee_rust_examples_ext-1.0/.stamp_configured] Error 1
2025-03-04T10:15:19.3405144Z make[2]: *** Waiting for unfinished jobs....