core: using native interrupt handlers - #192
Conversation
jforissier
left a comment
jforissier
left a comment
There was a problem hiding this comment.
Comments below, then:
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
Thanks for the review @jforissier. I won't apply your review tag until OP-TEE/optee_os#5954 (or equivament) is merged, as this P-R adds a description for something that is not yet supported in OP-TEE core.
| platform. When used, the platform must provide a secure devicetree blob | ||
| (DTB) which platform and device drivers can use to getreferences to | ||
| interrupt controllers and relative interrupt numbers theyconsume. | ||
| Main API functions are: |
There was a problem hiding this comment.
The main
Ok, thanks.
(some definite articles are missing in a few other places I believe but my English is not good enough to decide it omitting them is OK or not).
mine neither ;)
|
LGTM you may squash the commits if you want, I will hold off merging this until there is code to actually implement it. |
|
I'll remove commit "faq: Fix typo" that is completely unrelated and already addressed by #190. Sorry for the noise. |
|
review comments addressed |
|
|
|
My ack still holds. |
Adds a section in core architecture documentation on how to implement and register interrupt controllers and handler functions. Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Joakim Bech <joakim.bech@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
|
squashed and applied review tags. Please remember to not merge this change until OP-TEE/optee_os#5954 (or equiv) is merged. |
Update description to P-R #5954 latest state: - update function labels - mask/unmask operation handlers are required and enable/disable are optional. - mention itr_chip_init() and interrupt_main_init(). Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
|
Updated according to OP-TEE/optee_os#5954 latest state. |
Fixes a example code snippet. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
Explains how the using an async notifier and an interrupt handler to relax CPU in a thread task. Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
|
Added a fixup commit for a typo in the provided example. Added a section exampling how to use aysnc notif + an interrupt to relax CPU in a thread execution context.
|
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
4 participants
The P-R is related to OP-TEE/optee_os#5954.
It adds a section in core architecture documentation on how to implement and register interrupt controllers and handler functions.