Skip to content

regression 1040: test interrupt notification - #640

Closed
etienne-lms wants to merge 2 commits into
OP-TEE:masterfrom
etienne-lms:it-notif
Closed

regression 1040: test interrupt notification#640
etienne-lms wants to merge 2 commits into
OP-TEE:masterfrom
etienne-lms:it-notif

Conversation

@etienne-lms

@etienne-lms etienne-lms commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Adds regression test 1040 to invoke a new Invoke test PTA command that triggers interrupt notification tests. When the command is not supported or Invoke test PTA not embedded, the test is skipped.

Related to OP-TEE/optee_os#5793 and some Linux kenrel changes listed in that P-R.

Adds regression test 1040 to invoke a new Invoke test PTA command that
triggers interrupt notification tests. When the command is not supported
or Invoke test PTA not embedded, the test is skipped.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Comment thread host/xtest/regression_1000.c Outdated
res = TEEC_InvokeCommand(&session, PTA_INVOKE_TESTS_CMD_IT_NOTIF_TESTS,
NULL, &ret_orig);
if (res != TEEC_SUCCESS) {
(void)ADBG_EXPECT_TEEC_ERROR_ORIGIN(c, TEEC_ORIGIN_TRUSTED_APP,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these (void) casts.

Remove (void) casts realted to unused return values.
Renames IT_NOTIF to ITR_NOTIF.
Moves inline comment to more appropriate locations.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
@github-actions

github-actions Bot commented Mar 2, 2023

Copy link
Copy Markdown

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants