xtest: add test for ECDH with invalid points - #818
Merged
Conversation
Contributor
Author
|
Based on the attached xtest patch in GHSA-g6qf-hwf7-mg9h |
Contributor
|
|
Adds four subtests checking that ECDH fails when the public key is a point that is not on the correct curve, which need to be rejected to avoid invalid curve attacks. Since TEE_DeriveKey() doesn't allow returning errors the TA will panic in the correct case. The tests use four test vectors from Wycheproof, selected in an attempt to avoid failures due to other checks that are independent of the curve check. Signed-off-by: Martin Nyhus <martin@nyhus.dev> [JW: small fixups] Signed-off-by: Jens Wiklander <jenswi@kernel.org> Acked-by: Jerome Forissier <jerome.forissier@arm.com>
Contributor
Author
|
Squashed and tag applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four subtests checking that ECDH fails when the public key is a point that is not on the correct curve, which need to be rejected to avoid invalid curve attacks. Since TEE_DeriveKey() doesn't allow returning errors the TA will panic in the correct case.
The tests use four test vectors from Wycheproof, selected in an attempt to avoid failures due to other checks that are independent of the curve check.
[JW: fixup to use ta_crypt_cmd_derive_key()]