xtest: AES-GCM Key Wrapping/Unwrapping - #822
Open
Hussainity wants to merge 1 commit into
Open
Conversation
Author
|
This PR addresses: OP-TEE/optee_os#7853 |
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
etienne-lms
reviewed
Aug 10, 2026
etienne-lms
left a comment
etienne-lms
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Some minor comments.
Could you update the commit message header line to something like:
-xtest: AES-GCM Key Wrapping/Unwrapping
+xtest: pkcs11_1031: Test AES GCM key wrapping
Comment on lines
+10227
to
+10228
| ADBG_EXPECT_CK_OK(c, C_DestroyObject(session, unwrapped_key)); | ||
| unwrapped_key = CK_INVALID_HANDLE; |
Contributor
There was a problem hiding this comment.
Could remove these 2 instructions.
If the function failed, no unwrap key should be created. Maybe replace with:
if (!ADBG_EXPECT_TRUE(c, rv != CKR_OK) ||
!ADBG_EXPECT_COMPARE_UNSIGNED(c, unwrapped_key, ==, CK_INVALID_HANDLE))
goto out;
Author
There was a problem hiding this comment.
Agreed, out: takes care of it anyways.
Hussainity
force-pushed
the
hm/gcm-keywrap
branch
from
August 10, 2026 14:34
7d93ac0 to
bdbc487
Compare
Test AES-GCM Key Wrapping and Unwrapping in the PKCS#11 TA. Ensure that round-trip is succesful and that tampered tags are rejected. Signed-off-by: Hussain Miyaziwala <hussain_miya@hotmail.com>
Hussainity
force-pushed
the
hm/gcm-keywrap
branch
from
August 10, 2026 14:37
bdbc487 to
6918be9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test AES-GCM Key Wrapping and Unwrapping in the PKCS#11 TA. Ensure that round-trip is succesful and that tampered tags are rejected.