xtest: make the dev kit configuration a required input - #826
Merged
Conversation
jforissier
reviewed
Aug 3, 2026
jforissier
left a comment
jforissier
left a comment
Contributor
There was a problem hiding this comment.
Acked-by: Jerome Forissier <jerome.forissier@arm.com>
Turn the -include of the dev kit conf.mk into a hard include, so that a missing configuration fails the build. The CFG_ flags it carries select which tests are built, and -include accepts it missing: the flags come out empty and the tests they select are dropped from xtest with no diagnostic, which is issue OP-TEE#275. optee_os now generates the configuration while the Android makefiles are parsed, so conf.mk is there by the time this file is read. Signed-off-by: Andrii Shtompel <andrii_shtompel@epam.com> Acked-by: Jerome Forissier <jerome.forissier@arm.com>
andrew2311
force-pushed
the
xtest-dev-kit-conf
branch
from
August 3, 2026 15:46
836182b to
bbead2b
Compare
Contributor
|
Why is this still set to work-in-progress? Is anything missing before I can merge it? |
Contributor
I believe this is draft only due to the dependency on OP-TEE/optee_os#7897 |
Contributor
|
Thanks, I noticed that later. :-) |
andrew2311
marked this pull request as ready for review
August 6, 2026 12:44
Author
|
Ready to merge (dependency OP-TEE/optee_os#7897 was merged) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn the -include of the dev kit conf.mk into a hard include, so that a missing configuration fails the build.
The CFG_ flags it carries select which tests are built, and -include accepts it missing: the flags come out empty and the tests they select are dropped from xtest with no diagnostic, which is issue #275. optee_os now generates the configuration while the Android makefiles are parsed, so conf.mk is there by the time this file is read.