Storage cache refinements #808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
jenkins build this please |
Member
Author
|
jenkins build this please |
bska
reviewed
Jun 2, 2023
| for (unsigned eqIdx = 0; eqIdx < numEq; ++eqIdx) { | ||
| tmp2[eqIdx] = Toolbox::value(tmp[eqIdx]); | ||
| } | ||
| if (!elemCtx.haveStashedIntensiveQuantities()) { |
Member
There was a problem hiding this comment.
Huh, interesting. I'd not come across that function before. Its documentation is a little hard to comprehend though, since it states that the function
returns
trueif NO intensive quantities are stashed
Is that accurate?
Member
Author
There was a problem hiding this comment.
I have also not really come across it. The mechanism is used to stash away data for a cell before perturbing the element context for finite difference derivative evaluations, and then restoring it afterwards, so its removal from the logic made such cases fail.
The doc is wrong...
Member
Author
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the old and new linearizers behave in the same way, and the code is a bit simpler and clearer. Builds on and replaces #772
Some changes here are directly #772 so I made @totto82 the author, but the commits are new here and not cherry-picked from the other branch.