- changed assert to throw #829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added more tests
blattms
reviewed
Sep 21, 2023
|
|
||
| #ifndef NDEBUG | ||
| // some safety checks in debug mode | ||
| #ifndef NOT_CHECK_STATE |
Member
There was a problem hiding this comment.
Why the new name (that nobody knows)?
Member
Author
There was a problem hiding this comment.
Becase NDEBUG is on in production code.
Member
There was a problem hiding this comment.
Becase NDEBUG is on in production code.
I think you meant NDEBUG is off in production code with default -DWITH_NDEBUG=0
-O3 -DNDEBUG -mtune=native -UNDEBUG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Saturation is not checked