Eq lopt3 tilt #6519
Draft
Eq lopt3 tilt #6519
+658
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitPaean
added
the
manual:new-feature
ElyesAhmed
force-pushed
the
eqLOPT3-tilt
branch
from
549d453 to
01061cb
Compare
| auto elemIt = gridView.template begin</*codim=*/0>(); | ||
| const auto& elemEndIt = gridView.template end</*codim=*/0>(); | ||
| centroids_.resize(gridView.size(0)); | ||
| for (; elemIt != elemEndIt; ++elemIt) { |
Member
There was a problem hiding this comment.
unconventional to not just define elemIt in the loop header
Contributor
Author
There was a problem hiding this comment.
not fixed since same is used in many other locations (will keep this fix for some clean-up later)
| rec[r], this->rsFunc_[r], this->rvFunc_[r], this->rvwFunc_[r], | ||
| this->tempVdTable_[r], this->saltVdTable_[r], this->regionPvtIdx_[r] | ||
| }; | ||
| vspan[0] = std::min(vspan[0], std::min(eqreg.zgoc(), eqreg.zwoc())); |
Member
There was a problem hiding this comment.
std::min({a, b, c}) again here
Contributor
Author
There was a problem hiding this comment.
not fixed since same is used in many other locations (will keep this fix for some clean-up later)
| rec[r], this->rsFunc_[r], this->rvFunc_[r], this->rvwFunc_[r], | ||
| this->tempVdTable_[r], this->saltVdTable_[r], this->regionPvtIdx_[r] | ||
| }; | ||
| vspan[0] = std::min(vspan[0], std::min(eqreg.zgoc(), eqreg.zwoc())); |
Member
There was a problem hiding this comment.
std::min({a, b, c}) again here
Contributor
Author
There was a problem hiding this comment.
not fixed since same is used in many other locations (will keep this fix for some clean-up later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR introduces experimental support for the EQUIL keyword with N>0 input parameter on tilted fault blocks. The implementation explores different approaches to handle tilted grid geometries in equilibrium initialization.
Changes Made
Added support for tilted grid equilibration when N>0 is specified in the EQUIL keyword
Simplified approach: Uses dip angle to estimate weighting factors for tilted cells
Complex one approach: Computes actual horizontal cross-section areas at different depths (more accurate but computationally very expensive on Volve)
TESTS