Skip to content

Added support for os2web_key #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 60 commits into
base: develop
Choose a base branch
from
Open

Added support for os2web_key #101

wants to merge 60 commits into from

Conversation

rimi-itk
Copy link
Collaborator

@rimi-itk rimi-itk commented Apr 26, 2024 •
edited
Loading

Caution

The feature/os2web_key branch in this pull request is branched from feature/code-cleanup and therefore the pull request Code clean-up #168 should be addressed – and merged – before code reviewing this pull request.

@rimi-itk rimi-itk force-pushed the feature/os2web_key branch 3 times, most recently from 1141148 to fc90fbe Compare May 1, 2024 15:07
@rimi-itk rimi-itk force-pushed the feature/os2web_key branch 3 times, most recently from 5ae3ae7 to b274156 Compare May 7, 2024 12:58
@rimi-itk rimi-itk marked this pull request as ready for review May 13, 2024 07:48
@rimi-itk rimi-itk changed the base branch from develop to 4.0.x May 13, 2024 08:43
@rimi-itk rimi-itk changed the base branch from 4.0.x to develop May 13, 2024 08:48
@rimi-itk rimi-itk requested a review from jekuaitk May 15, 2024 07:44
@rimi-itk rimi-itk force-pushed the feature/os2web_key branch from 37f77e4 to d82195e Compare May 16, 2024 07:35
@rimi-itk
Moved digital post settings into config. Added support for os2web_key…
92c0ec4 
… to get certificate.

# Conflicts:
#	CHANGELOG.md
#	composer.json
#	modules/os2forms_digital_post/src/Helper/CertificateLocatorHelper.php
#	modules/os2forms_digital_post/src/Helper/DigitalPostHelper.php
@rimi-itk
Cleaned up Markdown
b07e536
@rimi-itk
Cleaned up
0f6900d
@rimi-itk
Required os2web_key 1.0
ae2c683
@rimi-itk
Updated os2web_datalookup
801cae9
@jekuaitk jekuaitk requested a review from stankut April 24, 2025 12:43
@jekuaitk jekuaitk force-pushed the feature/os2web_key branch from c4fd652 to 6ba43e9 Compare April 24, 2025 13:33
stankut
stankut reviewed Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@stankut stankut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Most of my comments here are about how the changes are grouped. I see there have been a lot of refactoring changes—this is superb! However, these are currently mixed with new functionality, such as the addition of the os2web_key module, which makes the overall changeset look cluttered.

My suggestion is to try to keep different types of changes separate—perhaps by grouping them into two or three additional PRs.

.github/workflows/pr.yml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring github workflow.
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

.gitignore Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring general files in repository.
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

.markdownlint.jsonc Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring general files in repository.
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

.markdownlintrc Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring general files in repository.
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

CHANGELOG.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are to keep the refactoring of the file not related with the new functionality (os2web_key), that must be reflected in CHANGELOG.
my suggestion is to make that as part of separate PR.

package.json Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring other files in repository (not related with os2web_key)
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

scripts/code-analysis Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring other files in repository (not related with os2web_key)
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

modules/os2forms_digital_post/src/Helper/Settings.php Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring other files in repository (not related with os2web_key)
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

modules/os2forms_fasit/src/Form/SettingsForm.php Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring other files in repository (not related with os2web_key)
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

modules/os2forms_fasit/src/Helper/Settings.php Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating/refactoring other files in repository (not related with os2web_key)
In my opinion it would clearer to make it as part of the separate/dedicated PR, not to mix it with new functionality.

rimi-itk added 4 commits April 29, 2025 13:46
@rimi-itk
Cleaned up code
a538d3d
@rimi-itk
Merge branch 'feature/code-cleanup' into feature/os2web_key
6565068 
# Conflicts:
#	.github/workflows/pr.yml
#	CHANGELOG.md
#	README.md
#	composer.json
#	modules/os2forms_dawa/src/Plugin/os2web/DataLookup/DatafordelerDataLookup.php
#	modules/os2forms_digital_post/src/Drush/Commands/DigitalPostTestCommands.php
@rimi-itk
Updated os2web/os2web_datalookup
b182805
@rimi-itk
Enabled os2web_key module
dabb887
@rimi-itk
Copy link
Collaborator Author

Hi!

Most of my comments here are about how the changes are grouped. I see there have been a lot of refactoring changes—this is superb! However, these are currently mixed with new functionality, such as the addition of the os2web_key module, which makes the overall changeset look cluttered.

My suggestion is to try to keep different types of changes separate—perhaps by grouping them into two or three additional PRs.

I totally agree, @stankut, and I cannot remember why I mixed everything together. I've moved the code cleanup stuff to a new pull request, #168.

@ds-bellcom ds-bellcom mentioned this pull request May 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stankut stankut stankut left review comments

@jekuaitk jekuaitk jekuaitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rimi-itk @stankut @jekuaitk