style: enable unused import pylint rule (W0611) and fix resulting violations #6668
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
python/grass/pygrass/modules/grid/testsuite/test_pygrass_modules_grid_doctests.py
Outdated
Show resolved
Hide resolved
echoix
reviewed
Nov 26, 2025
Member
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
Great work! Glad you found an easy one. I’m checking here with others about the underlying problems.
| # for now it is the only place where it works | ||
| grass.gunittest.utils.do_doctest_gettext_workaround() | ||
|
|
||
| # tests.addTests(doctest.DocTestSuite(gmodules.shortcuts)) |
Member
There was a problem hiding this comment.
@petrasovaa Do you remember how this test works and why it is commented out? It was the usage of the unused import
Contributor
There was a problem hiding this comment.
No, and no time to look at it now, so I am for removing the import.
| tests.addTests(doctest.DocTestSuite(grid.grid)) | ||
| tests.addTests(doctest.DocTestSuite(grid.patch)) | ||
| tests.addTests(doctest.DocTestSuite(grid.split)) | ||
| # tests.addTests(doctest.DocTestSuite(shortcuts)) |
Member
There was a problem hiding this comment.
Again, what is the shortcuts? It’s the source of the unused imports
…es_grid_doctests.py Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
How to handle the remaining 1000+ issues in the gui folder? |
Contributor
I am not sure I fully understand the output, but I think it's just 9 files, we could fix those. |
Member
|
If it’s really only this, sure it’s a good idea to fix these right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pylint rule W0611 (unused-import) and clean up code to comply.
Changes: