Support meta-data for suspicion reasons #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Represent suspicion reasons with a new Reason class that, in addition to the string identifier, supports a label and source/origin of the reason * Continue to store string identifiers in the Changeset.suspicion_reasons field for backward compatibility * Introduce a new Changeset.detailed_reasons field that has the full Reason objects * Use the Reason.source to track when suspicion reasons originated as warnings generated by an editor, such as iD * When printing suspicion reasons in the CLI, include the source of the reason if it was not from osmcha * Update unit tests
nrotstan
force-pushed
the
add-suspicion-reason-metadata
branch
from
688166d to
80716d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Represent suspicion reasons with a new Reason class that, in addition
to the string identifier, supports a label and source/origin of the
reason
Continue to store string identifiers in the
Changeset.suspicion_reasons field for backward compatibility
Introduce a new Changeset.detailed_reasons field that has the full
Reason objects
Use the Reason.source to track when suspicion reasons originated as
warnings generated by an editor, such as iD
When printing suspicion reasons in the CLI, include the source of the
reason if it was not from osmcha
Update unit tests