Initial commit for new comm protocol #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pchaya
commented
Jan 11, 2020
pchaya
commented
- Anthony's development for new comm protocol
Scarabax
requested review from
HarinderG,
andrewda,
chitali and
kira-the-engineer
HarinderG
reviewed
Jan 15, 2020
| time.sleep(0.0001) | ||
| acknowledge = self.port.read(4) | ||
| if (not(acknowledge == (bytes(b'\xff\xff\xff\xff')))): | ||
| print("Bad acknowledge!!!!mult") |
There was a problem hiding this comment.
Did you mean to print out "mult" after the Bad acknowledge?
Suggested change
| print("Bad acknowledge!!!!mult") | |
| print("Bad acknowledge!!!!") |
HarinderG
reviewed
Jan 15, 2020
| while(self.port.out_waiting): | ||
| time.sleep(0.0001) | ||
| acknowledge = self.port.read(4) | ||
| if (not(acknowledge == (bytes(b'\xff\xff\xff\xff')))): |
There was a problem hiding this comment.
You don't need bytes() method.
Suggested change
| if (not(acknowledge == (bytes(b'\xff\xff\xff\xff')))): | |
| if (not(acknowledge == b'\xff\xff\xff\xff')): |
HarinderG
reviewed
Jan 15, 2020
| while(self.port.out_waiting): | ||
| time.sleep(0.0001) | ||
| acknowledge = self.port.read(4) | ||
| if (not(acknowledge == (bytes(b'\xff\xff\xff\xff')))): |
There was a problem hiding this comment.
You don't need bytes() method.
Suggested change
| if (not(acknowledge == (bytes(b'\xff\xff\xff\xff')))): | |
| if (not(acknowledge == b'\xff\xff\xff\xff')): |
HarinderG
reviewed
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.