Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon for sorting component #856

Closed
kasya opened this issue Feb 16, 2025 · 4 comments · Fixed by #884
Closed

Update icon for sorting component #856

kasya opened this issue Feb 16, 2025 · 4 comments · Fixed by #884
Assignees
Labels

Comments

@kasya
Copy link
Collaborator

kasya commented Feb 16, 2025

Is your feature request related to a problem? Please describe.
The icons that we currently have on a SortBy component is a bit misleading. When the order set to Descending it means that we go from largest to smallest item, going down. Opposite for ascending order where we should go up from smallest to largest item.
Currently the icons are misleading in the direction of sorting, where descending shows arrow pointing up and ascending shows arrow pointing down.

Image
Image

Describe the solution you'd like
I think we should find a more appropriate icon that would show the direction of order more clear (down or up).
I checked FA icons and it seems that the fix could be as simple as changing the icons to these for Descending and for Ascending order.

@swastika1011
Copy link
Contributor

@arkid15r Can you assign this to me

@Sanskriti-Saran
Copy link
Contributor

@kasya Can you please assign this to me

@arkid15r arkid15r moved this from Backlog to In progress in Project Nest Feb 16, 2025
@arkid15r
Copy link
Collaborator

@swastika1011 and @Sanskriti-Saran you both qualify for this good first issue (@swastika1011 just replied first)

@arkid15r
Copy link
Collaborator

@Sanskriti-Saran consider #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants