Updated sorting icon functionality in SortBy.tsx #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramattamara
requested changes
Feb 18, 2025
|
Okay I'll make the necessary changes and update it. |
|
Hi @aramattamara, I have made few changes and tried to align it. If something doesn't seem right please let me know, I'll try to resolve it.
|
|
Looks nice! Thanks! Please fix tests and can be merged. |
|
Hey @aramattamara can you please check this now |
kasya
previously approved these changes
Feb 22, 2025
There was a problem hiding this comment.
Looks good to me! @aramattamara approve it when you think it's ready to go - I'll set it up to merge after your approval.
arkid15r
reviewed
Feb 22, 2025
There was a problem hiding this comment.
This is not supposed to require my approval. But it contains package-lock.json changes that are unrelated to the PR.
I'll take care of that.
@aramattamara @kasya thanks for reviewing!
arkid15r
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed sorting icon in SortBy.tsx
Resolves #856
Add the PR description here.
Updated the sorting icon in SortBy.tsx to use the correct component.
Before:
After:
