Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

720:Updated the map and map background for better visibility in dark mode #795

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

osamaahmed17
Copy link

@osamaahmed17 osamaahmed17 commented Feb 10, 2025

Resolves #720
This PR improves the theme toggle functionality by ensuring that ChapterMap updates in real-time when the theme is changed

I just removed the React tooltip that I previously committed and created a Theme Provider to handle the theme.

map.mp4

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link an issue to the PR.

@osamaahmed17
Copy link
Author

ok

@osamaahmed17 osamaahmed17 marked this pull request as draft February 12, 2025 21:55
@osamaahmed17 osamaahmed17 force-pushed the osamaahmed17/720 branch 2 times, most recently from 3eb1a76 to 5d83780 Compare February 13, 2025 09:09
@osamaahmed17 osamaahmed17 changed the title 720:Updated the map background for better visibility in dark mode 720:Updated the map and map background for better visibility in dark mode Feb 13, 2025
@osamaahmed17 osamaahmed17 marked this pull request as ready for review February 13, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Map dark mode background
2 participants