Add snapshot model #809

yashgoyal0110 · 2025-02-11T19:20:11Z

fixes: #800

arkid15r

I strongly suggest reconsidering the approach of working on tasks in general.

Please also add a minimal test coverage.

backend/apps/owasp/api/snapshot_service.py

backend/apps/owasp/management/commands/process_snapshots.py

backend/apps/owasp/models/snapshot.py

yashgoyal0110 · 2025-02-16T21:03:46Z

Hey @arkid15r

Test files are added
Migrations are generated
file names are corrected
unwanted files are removed
code checked on local

arkid15r

This looks better but I haven't run this code yet. Please look into these when you get a chance:

backend/apps/owasp/models/snapshot.py

backend/tests/owasp/models/snapshot_test.py

backend/apps/owasp/admin.py

backend/apps/owasp/management/commands/process_snapshots.py

backend/apps/owasp/models/snapshot.py

backend/tests/owasp/models/snapshot_test.py

arkid15r

Please squash the migrations into a single file to keep the migration history clean.

backend/apps/owasp/management/commands/process_snapshots.py

backend/tests/owasp/models/snapshot_test.py

backend/apps/owasp/migrations/0001_squashed_0019_alter_snapshot_options_and_more.py

arkid15r

LGTM

Merging this to drive the feature development forward

yashgoyal0110 requested a review from arkid15r as a code owner February 11, 2025 19:20

github-actions bot added the backend label Feb 11, 2025

yashgoyal0110 force-pushed the fix/snapshot-setup branch 2 times, most recently from 8232789 to 4b687e5 Compare February 11, 2025 19:35

snapshot-setup

54f5ebd

yashgoyal0110 force-pushed the fix/snapshot-setup branch from 4b687e5 to 54f5ebd Compare February 11, 2025 19:49

yashgoyal0110 added 2 commits February 12, 2025 01:44

snapshot-setup

2f65efd

snapshot-setup

58dd96b

arkid15r requested changes Feb 12, 2025

View reviewed changes

yashgoyal0110 and others added 3 commits February 12, 2025 10:30

Merge branch 'main' into fix/snapshot-setup

561a67d

Merge branch 'main' into fix/snapshot-setup

20e4322

commit

fe711d9

github-actions bot added the backend-tests label Feb 15, 2025

yashgoyal0110 and others added 5 commits February 16, 2025 20:52

Merge branch 'main' into fix/snapshot-setup

2550727

snapshot

bb94b5b

snapshot-setup

a4e132b

snapshot-setup

5a56bd9

snapshot

3d0bf28

yashgoyal0110 force-pushed the fix/snapshot-setup branch from 0037a2f to 3d0bf28 Compare February 16, 2025 19:47

snapshot

e358468

yashgoyal0110 force-pushed the fix/snapshot-setup branch from 18e85fa to e358468 Compare February 16, 2025 19:49

snapshot-changes

17fa869

yashgoyal0110 requested a review from arkid15r February 16, 2025 20:01

yashgoyal0110 added 2 commits February 17, 2025 02:27

snapshot tests

8d10f3b

snapshot tests

8bbf169

yashgoyal0110 force-pushed the fix/snapshot-setup branch from 2497634 to 8bbf169 Compare February 16, 2025 21:01

arkid15r requested changes Feb 17, 2025

View reviewed changes

backend/apps/owasp/models/snapshot.py Outdated Show resolved Hide resolved

backend/tests/owasp/models/snapshot_test.py Outdated Show resolved Hide resolved

yashgoyal0110 and others added 2 commits February 17, 2025 10:33

Merge branch 'main' into fix/snapshot-setup

5e071a4

snapshot changes

6b3a8c6

yashgoyal0110 requested a review from arkid15r February 17, 2025 05:19

Merge branch 'main' into fix/snapshot-setup

7c18be7

arkid15r requested changes Feb 20, 2025

View reviewed changes

yashgoyal0110 added 6 commits February 20, 2025 10:54

Merge branch 'main' into fix/snapshot-setup

b3f5e12

Merge branch 'main' into fix/snapshot-setup

b1b090b

commit

2837f4a

fixed

9425f7d

Merge branch 'main' into fix/snapshot-setup

bf154eb

tests

e7fde49

arkid15r requested changes Feb 21, 2025

View reviewed changes

backend/apps/owasp/management/commands/process_snapshots.py Outdated Show resolved Hide resolved

backend/tests/owasp/models/snapshot_test.py Outdated Show resolved Hide resolved

backend/tests/owasp/models/snapshot_test.py Show resolved Hide resolved

fixed

b10e939

yashgoyal0110 force-pushed the fix/snapshot-setup branch from c486e46 to b10e939 Compare February 21, 2025 17:24

yashgoyal0110 requested a review from arkid15r February 21, 2025 17:30

arkid15r reviewed Feb 22, 2025

View reviewed changes

backend/apps/owasp/migrations/0001_squashed_0019_alter_snapshot_options_and_more.py Outdated Show resolved Hide resolved

fixed migrations

21188a0

yashgoyal0110 force-pushed the fix/snapshot-setup branch from e17a45d to 21188a0 Compare February 22, 2025 18:42

arkid15r added 2 commits February 22, 2025 11:19

Merge branch 'main' into pr/yashgoyal0110/809

0e53472

Update code

e72d8bc

github-actions bot added the makefile label Feb 22, 2025

arkid15r changed the title ~~snapshot-setup~~ Add snapshot model Feb 22, 2025

Update tests

8324e96

arkid15r approved these changes Feb 22, 2025

View reviewed changes

arkid15r enabled auto-merge February 22, 2025 19:34

arkid15r added this pull request to the merge queue Feb 22, 2025

Merged via the queue into OWASP:main with commit fb3ff03 Feb 22, 2025
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add snapshot model #809

Add snapshot model #809

yashgoyal0110 commented Feb 11, 2025

arkid15r left a comment

yashgoyal0110 commented Feb 16, 2025

arkid15r left a comment

arkid15r left a comment

arkid15r left a comment

Add snapshot model #809

Add snapshot model #809

Conversation

yashgoyal0110 commented Feb 11, 2025

arkid15r left a comment

Choose a reason for hiding this comment

yashgoyal0110 commented Feb 16, 2025

arkid15r left a comment

Choose a reason for hiding this comment

arkid15r left a comment

Choose a reason for hiding this comment

arkid15r left a comment

Choose a reason for hiding this comment