Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added main page #885

Merged
merged 26 commits into from
Feb 22, 2025
Merged

Added main page #885

merged 26 commits into from
Feb 22, 2025

Conversation

abhayymishraa
Copy link
Collaborator

Resolves #297

Add the PR description here.

  • Added the component and searchbar
  • Modified the backend according to it
  • Added counter effect on the counter

Preview/Screenshot

Screencast.from.19-02-25.02.13.16.AM.IST.webm

@abhayymishraa
Copy link
Collaborator Author

abhayymishraa commented Feb 19, 2025

  • Completed a unified search bar

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General UI improvement suggestions:

  • add leaders for the recently added project/chapter cards
  • remove issues and contributors from the recently added project/chapter cards
  • remove region or whatever it is (Africa, North America) from chapter card
  • add creation date to chapter card
  • make project/chapter cards metadata look similar in style (2 rows with leaders and other metadata)
  • on the chapters map we should either show all chapters on the big map or chapters nearest to the user only (smaller map)
  • recent issues and recent releases can be combined similar to projects/chapters widgets
  • are the bottom page counter accurate?

Additional items to take care of later:

  • for Top contributors we want to exclude some accounts like OWASP Foundation, and OWASP staff accounts (its their job)

@abhayymishraa
Copy link
Collaborator Author

yes bottom page counter is accurate

@abhayymishraa
Copy link
Collaborator Author

  • remove issues and contributors from the recently added project/chapter cards
  • remove region or whatever it is (Africa, North America) from chapter card
  • add creation date to chapter card
  • recent issues and recent releases can be combined similar to projects/chapters widgets

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting closer! Great work, please look into these suggestions when you get a chance:

@abhayymishraa
Copy link
Collaborator Author

Let's add some repository data too (I guess name should be enough) and show it on the frontend as a link instead of just 12345 contributions text

About this suggestion: -
i didn't quite get this suggestion so i have made the following changes
Screenshot from 2025-02-22 14-21-26

i have added repo name and the link to the repo onClick the repo name
If it required more that what i did , happy to change it in next review

@swastika1011
Copy link
Contributor

Resolves #297

Add the PR description here.

  • Added the component and searchbar
  • Modified the backend according to it
  • Added counter effect on the counter

Preview/Screenshot

Screencast.from.19-02-25.02.13.16.AM.IST.webm

Hey @abhayymishraa, The frontend looks great! The design is clean and well-structured. One small suggestion- based on this video, the main page appears a bit vacant on the left and right sides. Maybe adding some elements or adjusting the layout could make it feel more balanced. I might be wrong, but just wanted to share my observation.

@abhayymishraa
Copy link
Collaborator Author

abhayymishraa commented Feb 22, 2025

Resolves #297
Add the PR description here.

  • Added the component and searchbar
  • Modified the backend according to it
  • Added counter effect on the counter

Preview/Screenshot
Screencast.from.19-02-25.02.13.16.AM.IST.webm

Hey @abhayymishraa, The frontend looks great! The design is clean and well-structured. One small suggestion- based on this video, the main page appears a bit vacant on the left and right sides. Maybe adding some elements or adjusting the layout could make it feel more balanced. I might be wrong, but just wanted to share my observation.

@swastika1011
Thanks for the suggestion! I noticed that too, but I aimed for consistency across all pages. This is just the initial version of the main page, and we’ll be adding more features soon to make better use of the space. I appreciate the feedback!

@arkid15r arkid15r enabled auto-merge February 22, 2025 20:28
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice work, let's build on top of this 👍

@arkid15r arkid15r added this pull request to the merge queue Feb 22, 2025
Merged via the queue into OWASP:main with commit 9dd1035 Feb 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design and implement main page layout
3 participants