Added nest app and slack command for sponsorship #947
+463
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhayymishraa
force-pushed
the
feat/sponsorship-program
branch
from
07f5706 to
e7f54b1
Compare
arkid15r
requested changes
Feb 28, 2025
| related_name="sponsorships", | ||
| ) | ||
|
|
||
| class Meta: |
| @@ -65,6 +83,48 @@ def get_news_data(limit=10, timeout=30): | |||
| return items | |||
|
|
|||
|
|
|||
| def get_or_create_issue(issue_link): | |||
There was a problem hiding this comment.
This scope is to broad for /sponsor command's function. Let's split it and remove from here.
Comment on lines
+104
to
+125
| try: | ||
| return Issue.objects.get(url=issue_link) | ||
| except Issue.DoesNotExist: | ||
| pass | ||
|
|
||
| github_client = Github(settings.GITHUB_TOKEN) | ||
| issue_number = int(parts[6]) | ||
| owner = parts[3] | ||
| repo_name = parts[4] | ||
|
|
||
| try: | ||
| # Fetch the repository and issue from GitHub | ||
| gh_repo = github_client.get_repo(f"{owner}/{repo_name}") | ||
| gh_issue = gh_repo.get_issue(issue_number) | ||
| repository = Repository.objects.get(name=repo_name) | ||
| author = User.objects.get(login=gh_issue.user.login) | ||
|
|
||
| # Update or create the issue in the database | ||
| return Issue.update_data(gh_issue, author=author, repository=repository) | ||
| except Exception as e: | ||
| logger.exception("Failed to fetch issue from GitHub: %s") | ||
| raise ValidationError(FETCH_ISSUE_ERROR.format(error=e)) from e |
There was a problem hiding this comment.
This should be a part of github.common.py sync_issue()
Comment on lines
+118
to
+119
| repository = Repository.objects.get(name=repo_name) | ||
| author = User.objects.get(login=gh_issue.user.login) |
There was a problem hiding this comment.
These may not exist yet.
There was a problem hiding this comment.
yes what did you suggest create user or repository too ?(if it not exist in the database?
|
|
||
| # Extract repository owner, repo name, and issue number from the issue link | ||
| # Example: https://github.com/OWASP/Nest/issues/XYZ | ||
| parts = issue_link.strip("/").split("/") |
There was a problem hiding this comment.
Use urllib.parse.urlparse for this.
Comment on lines
+197
to
+234
| def validate_deadline(deadline_str): | ||
| """Validate that the deadline is in a valid datetime format.""" | ||
| try: | ||
| # Try parsing the deadline in YYYY-MM-DD format | ||
| deadline = datetime.strptime(deadline_str, "%Y-%m-%d").replace( | ||
| tzinfo=timezone.get_current_timezone() | ||
| ) | ||
| except ValueError: | ||
| try: | ||
| # Try parsing the deadline in YYYY-MM-DD HH:MM format | ||
| deadline = datetime.strptime(deadline_str, "%Y-%m-%d %H:%M").replace( | ||
| tzinfo=timezone.get_current_timezone() | ||
| ) | ||
| except ValueError as e: | ||
| raise ValidationError(DEADLINE_FORMAT_ERROR) from e | ||
|
|
||
| if deadline < timezone.now(): | ||
| raise ValidationError(DEADLINE_FUTURE_ERROR) | ||
|
|
||
| return deadline | ||
|
|
||
|
|
||
| def validate_github_issue_link(issue_link): | ||
| """Validate that the issue link belongs to a valid OWASP-related repository.""" | ||
| if not issue_link.startswith("https://github.com/OWASP"): | ||
| raise ValidationError(ISSUE_LINK_ERROR) | ||
| return issue_link | ||
|
|
||
|
|
||
| def validate_price(price): | ||
| """Validate that the price is a positive float value.""" | ||
| try: | ||
| price = float(price) | ||
| if price <= 0: | ||
| raise ValidationError(PRICE_POSITIVE_ERROR) | ||
| except ValueError as e: | ||
| raise ValidationError(PRICE_VALID_ERROR) from e | ||
| return price |
There was a problem hiding this comment.
These validators belong with Snapshot model, definitely not here.
There was a problem hiding this comment.
Snapshot model ? really?
There was a problem hiding this comment.
i think you meant sponsorship model !!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #916
Add the PR description here.
Screenshot/Preview
Results with command