Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made org and location clickable on user detail page #948

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

jaiakash
Copy link
Contributor

Resolves #946

Add clickable org and location on the user details page.

Screenshot 2025-02-27 at 9 12 20 PM

Signed-off-by: Akash Jaiswal <[email protected]>
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaiakash this works and resolves the issue you suggested.
Do you think we could extend this and cover @github-entity style accounts from user's bio too?

Screenshot 2025-02-27 at 11 57 11 AM

@arkid15r arkid15r enabled auto-merge February 27, 2025 19:57
@jaiakash
Copy link
Contributor Author

jaiakash commented Feb 27, 2025

@jaiakash this works and resolves the issue you suggested.

Do you think we could extend this and cover @github-entity style accounts from user's bio too?

Screenshot 2025-02-27 at 11 57 11 AM

I mean we can 🤔🤔 but not always that would be github org/account.

Plus if we are manually parsing text after @ as link then there might be false positive.

@arkid15r arkid15r added this pull request to the merge queue Feb 27, 2025
Merged via the queue into OWASP:main with commit 3f167d4 Feb 27, 2025
16 checks passed
@arkid15r
Copy link
Collaborator

@jaiakash this works and resolves the issue you suggested.
Do you think we could extend this and cover @github-entity style accounts from user's bio too?
Screenshot 2025-02-27 at 11 57 11 AM

I mean we can 🤔🤔 but not always that would be github org/account.

Plus if we are manually parsing text after @ as link then there might be false positive.

You're right but it's mostly GH accounts. Would you like to create a separate issue and work on this too?

@jaiakash
Copy link
Contributor Author

jaiakash commented Feb 27, 2025

You're right but it's mostly GH accounts. Would you like to create a separate issue and work on this too?

fine no issue. i will create issue and send PR. #950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: improve user detail page
2 participants