Add lint workflow using [email protected]

Add .jshintignore to skip slow/irrelevant linting of node_modules and
vendor js.

Add [email protected] as a top-level devDependency to guarantee it's
available for use from the shell. Upgrade grunt-contrib-jshint to use
[email protected] and pin grunt at ^1.0.3 since that's already in the
lockfile and is required by [email protected].

Update grunt config to watch/jshint the same files as standalone jshint

.github/workflows/lint.yml

@@ -0,0 +1,26 @@
+name: Lint
+on: [push, pull_request]
+
+jobs:
+  lint:
+    name: Node.js
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: ["14.x"]
+
+    steps:
+      - name: Checkout https://github.com/${{ github.repository }}@${{ github.ref }}
+        uses: actions/checkout@v2
+        with:
+          persist-credentials: false
+
+      - name: Set up Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Run linter
+        run: npx --no-install [email protected] .

.jshintignore

@@ -0,0 +1,2 @@
+node_modules/
+app/assets/vendor/

Gruntfile.js

@@ -2,23 +2,31 @@
 
 var exec = require("child_process").exec;
 
-var JS_FILES = ["Gruntfile.js", "app/assets/js/**", "config/config.js", "app/data/**/*.js",
-    "app/routes/**/*.js", "server.js", "test/**/*.js"
+var APP_JS_FILES = ["app/assets/js/**/*.js", "config/**/*.js", "app/data/**/*.js",
+    "app/routes/**/*.js", "server.js"
 ];
 
+var SUPPORT_JS_FILES = ["Gruntfile.js", "artifacts/**/*.js", "test/**/*.js"];
+
+var JS_FILES = APP_JS_FILES.concat(SUPPORT_JS_FILES);
+
 
 module.exports = function(grunt) {
     // Project Configuration
     grunt.initConfig({
         pkg: grunt.file.readJSON("package.json"),
         watch: {
             js: {
-                files: JS_FILES,
+                files: APP_JS_FILES,
                 tasks: ["jshint"],
                 options: {
                     livereload: true
                 }
             },
+            support: {
+                files: SUPPORT_JS_FILES,
+                tasks: ["jshint"]
+            },
             html: {
                 files: ["app/views/**"],
                 options: {

package.json

@@ -42,17 +42,18 @@
     "async": "^2.0.0-rc.4",
     "cross-env": "^7.0.2",
     "cypress": "^3.3.1",
-    "grunt": "^1.0.1",
+    "grunt": "^1.0.3",
     "grunt-cli": "^1.2.0",
     "grunt-concurrent": "^2.3.0",
-    "grunt-contrib-jshint": "^1.0.0",
+    "grunt-contrib-jshint": "^3.0.0",
     "grunt-contrib-watch": "^1.0.0",
     "grunt-env": "latest",
     "grunt-if": "https://github.com/binarymist/grunt-if/tarball/master",
     "grunt-jsbeautifier": "^0.2.12",
     "grunt-mocha-test": "^0.12.7",
     "grunt-npm-install": "^0.3.0",
     "grunt-retire": "^0.3.12",
+    "jshint": "2.12.0",
     "mocha": "^2.4.5",
     "nodemon": "^1.19.1",
     "selenium-webdriver": "^2.53.2",