-
Notifications
You must be signed in to change notification settings - Fork 61
MyOpenCRE: add inline help for CSV preparation #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PRAteek-singHWY
wants to merge
23
commits into
OWASP:main
Choose a base branch
from
PRAteek-singHWY:myopencre-help-guide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi maintainers, just a gentle ping when you get a chance 🙂 |
- Validate file type, encoding, and required headers - Accept CSVs generated from CRE catalogue export - Skip empty and padding rows present in exported templates - Validate CRE format only when CRE references exist - Guard against misaligned rows with extra columns - Return structured validation errors before import This keeps the importer aligned with the exporter while preventing malformed inputs from causing server errors.
53e38a1 to
03f103b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR after the above PR has been merged.
📝 Note for reviewers
This PR intentionally limits its scope to frontend-only changes in the following files:
application/frontend/src/pages/MyOpenCRE/MyOpenCRE.tsxapplication/frontend/src/pages/MyOpenCRE/MyOpenCRE.scssNo backend files, APIs, or import logic were modified.
Any additional file diffs shown by GitHub are inherited from branch history or stacked branches and are not part of this change.
Summary
This PR improves the MyOpenCRE upload experience by adding lightweight,
inline guidance for users preparing a CSV mapping file.
The goal is to clarify what MyOpenCRE is and how to prepare a valid CSV
without changing behavior or adding complexity.
What changed
<details>/<summary>for a minimal, accessible UIScope
Screenshots
Why this helps