Skip to content

Conversation

@dlewburg
Copy link

@dlewburg dlewburg commented Dec 4, 2025

Summary:

closes #1350

Description for the changelog:

list elements inside and crossing trust boundaries

Declaration:

  • appropriate unit tests have been created / modified
  • functional tests created / modified for changes in functionality
  • any use of AI has been declared in this pull request

Other info:

Thanks for submitting a pull request!
Please make sure you follow our Code of Conduct
and our contributing guidelines

ssuram1 and others added 4 commits November 26, 2025 14:45
Successfully got IDs of elements contained within trust boundaries (boxes) to display in the JSON file
IDs of flows that cross trust boundaries and IDs of boundaries that flows cross also displayed in JSON
@KelseyVDB
Copy link

Closes #1350

@jgadsden jgadsden added the enhancement New feature or request label Dec 5, 2025
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dlewburg , many thanks for this feature, just a few things to get it ready for review
Could you revert all three package lock files so that they are not included in the pulk request? These files only need to be updated if there is a change in package.json
Could you provide more detail in the pull request description?
And on a very minor point there is some indentation in the schema files that could be made consistent

Reverted package-lock files and made identation consistent in schema files
@jgadsden
Copy link
Collaborator

jgadsden commented Dec 6, 2025

thanks for the updates @dlewburg , you can use npm test from the command line to run the unit tests

@jgadsden jgadsden marked this pull request as draft December 6, 2025 07:16
@jgadsden jgadsden marked this pull request as ready for review December 6, 2025 21:51
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dlewburg
very much appreciated, it all works as required and has the unit tests in place

@lreading this is a good stepping stone for the changes in the file format we are planning , where we use TM-BOM schema. TM-BOM has cross references for components in threat boundaries and data-flows crossing boundaries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trust Boundary Crossing Data Flow

5 participants