-
-
Notifications
You must be signed in to change notification settings - Fork 323
Feature/trust boundary data flow #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Successfully got IDs of elements contained within trust boundaries (boxes) to display in the JSON file IDs of flows that cross trust boundaries and IDs of boundaries that flows cross also displayed in JSON
…/ssuram1/threat-dragon into feature/trust-boundary-data-flow
|
Closes #1350 |
jgadsden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dlewburg , many thanks for this feature, just a few things to get it ready for review
Could you revert all three package lock files so that they are not included in the pulk request? These files only need to be updated if there is a change in package.json
Could you provide more detail in the pull request description?
And on a very minor point there is some indentation in the schema files that could be made consistent
Reverted package-lock files and made identation consistent in schema files
|
thanks for the updates @dlewburg , you can use |
jgadsden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dlewburg
very much appreciated, it all works as required and has the unit tests in place
@lreading this is a good stepping stone for the changes in the file format we are planning , where we use TM-BOM schema. TM-BOM has cross references for components in threat boundaries and data-flows crossing boundaries
Summary:
closes #1350
Description for the changelog:
list elements inside and crossing trust boundaries
Declaration:
Other info:
Thanks for submitting a pull request!
Please make sure you follow our Code of Conduct
and our contributing guidelines