Fix/update the content of HttpOnly Page #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Jan 13, 2025
| Since Java Enterprise Edition 6 (JEE 6), which adopted Java Servlet 3.0 | ||
| technology, it's programmatically easy to set the HttpOnly flag on a | ||
| cookie. | ||
| for more information , plwase check [Java EE to Jakarta EE Transition](https://jakarta.ee/about/faq/#what-is-the-java-ee-to-jakarta-ee-transition). |
| cookie.setHttpOnly(true); // Mark the cookie as HttpOnly | ||
| response.addCookie(cookie); | ||
| ``` | ||
| Moreover, since Jakarta EE 9, it's also declaratively easy to set the `HttpOnly` flag for session cookies by applying the following configuration in the deployment descriptor `WEB-INF/web.xml`: |
There was a problem hiding this comment.
The example seems the same as the v6 example, so saying since v9 is misleading
| response.setHeader("SET-COOKIE", "JSESSIONID=" + sessionid + "; HttpOnly"); | ||
|
|
||
| import jakarta.servlet.http.Cookie; | ||
| Cookie cookie = new Cookie("sessionId", "abc123"); |
There was a problem hiding this comment.
This doesn't seem like a practical example for a security community
There was a problem hiding this comment.
Additionally the code seems exactly the same as above so why bother?? Why not make the other "since 8" and skip the 9 example?
| In fact, the `setHttpOnly` and `isHttpOnly` methods are available in the [`jakarta.servlet.http.Cookie`](https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/Cookie.html) interface, as well as for session cookies (`JSESSIONID`) using [`jakarta.servlet.SessionCookieConfig`](https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/SessionCookieConfig.html): | ||
|
|
||
| ```java | ||
| Cookie cookie = new Cookie("sessionId", "abc123"); |
There was a problem hiding this comment.
This doesn't seem like a practical example for a security community
|
@YourBroCode do you plan to finish this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the content of HttpOnly Page according to the JEE 9 regarding cookie check.