-
Notifications
You must be signed in to change notification settings - Fork 693
Adds IntensityOcTree: per-voxel intensity payload for OctoMap #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
viplix3
wants to merge
12
commits into
OctoMap:devel
Choose a base branch
from
viplix3:feature/add-intensity
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+508
−0
Open
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b860edf
Adds intensity-based Octree
viplix3 3388305
Improves intensity propagation in IntensityOcTree
viplix3 c0aac24
Improves IntensityOcTree node handling
viplix3 4a2f28c
Adds IntensityOcTree source file to CMakeLists
viplix3 9cddbbb
Improves intensity occupancy update
viplix3 b80e78c
Adds computeUpdateKeys to IntensityOcTree
viplix3 540f48a
Refactors inner node occupancy update
viplix3 d7c9946
Adds IntensityOcTree and corresponding tests to CMakeLists
viplix3 4235324
Apply suggestions from code review
viplix3 2a5ca33
Refactor intensity tree tests for clarity and accuracy
viplix3 229dd91
Add isNodeCollapsible method and improve intensity comparison in Inte…
viplix3 96eefdc
Update octomap/include/octomap/IntensityOcTree.h
viplix3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| /* | ||
| * OctoMap - An Efficient Probabilistic 3D Mapping Framework Based on Octrees | ||
| * https://octomap.github.io/ | ||
| * | ||
| * Copyright (c) 2009-2013, K.M. Wurm and A. Hornung, University of Freiburg | ||
| * All rights reserved. | ||
| * License: New BSD | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. | ||
| * * Neither the name of the University of Freiburg nor the names of its | ||
| * contributors may be used to endorse or promote products derived from | ||
| * this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
| * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE | ||
| * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #ifndef OCTOMAP_INTENSITY_OCTREE_H | ||
| #define OCTOMAP_INTENSITY_OCTREE_H | ||
|
|
||
| #include <iostream> | ||
|
|
||
| #include <octomap/OcTreeNode.h> | ||
| #include <octomap/OccupancyOcTreeBase.h> | ||
|
|
||
| namespace octomap | ||
| { | ||
|
|
||
| // forward declaration for "friend" | ||
| class IntensityOcTree; | ||
|
|
||
| // node definition | ||
| class IntensityOcTreeNode : public OcTreeNode | ||
| { | ||
| public: | ||
| friend class IntensityOcTree;// needs access to node children (inherited) | ||
|
|
||
| // Constructors | ||
| IntensityOcTreeNode() : OcTreeNode(), intensity(0.0) | ||
| { | ||
| } | ||
|
|
||
| IntensityOcTreeNode(const IntensityOcTreeNode &rhs) | ||
| : OcTreeNode(rhs), intensity(rhs.intensity) | ||
| { | ||
| } | ||
|
|
||
| // Comparator | ||
| bool operator==(const IntensityOcTreeNode &rhs) const | ||
| { | ||
| return (rhs.value == value && rhs.intensity == intensity); | ||
| } | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Payload helpers | ||
| inline double getIntensity() const | ||
| { | ||
| return intensity; | ||
| } | ||
| inline void setIntensity(double i) | ||
| { | ||
| intensity = i; | ||
| } | ||
|
|
||
| // Copy when replacing a node | ||
| void copyData(const IntensityOcTreeNode &from) | ||
| { | ||
| OcTreeNode::copyData(from); | ||
| this->intensity = from.getIntensity(); | ||
| } | ||
|
|
||
| // Update occupancy and intensity of inner nodes | ||
| inline void updateIntensityChildren(); | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| double getAverageChildIntensity() const; | ||
| inline bool isIntensitySet() const | ||
| { | ||
| return (ZERO_EPSILON < intensity); | ||
| } | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Serialisation and deserialisation | ||
viplix3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| std::istream &readData(std::istream &s); | ||
| std::ostream &writeData(std::ostream &s) const; | ||
|
|
||
| protected: | ||
| double intensity; | ||
| static constexpr double ZERO_EPSILON = 1e-6;// to avoid division by zero | ||
viplix3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }; | ||
|
|
||
| // tree definition | ||
| class IntensityOcTree : public OccupancyOcTreeBase<IntensityOcTreeNode> | ||
| { | ||
| public: | ||
| // Default constructor, sets resolution of leafs | ||
| IntensityOcTree(double resolution); | ||
|
|
||
| /// virtual constructor: creates a new object of same type | ||
| /// (Covariant return type requires an up-to-date compiler) | ||
| IntensityOcTree *create() const override | ||
| { | ||
| return new IntensityOcTree(resolution); | ||
| } | ||
|
|
||
| std::string getTreeType() const | ||
| { | ||
| return "IntensityOcTree"; | ||
| } | ||
|
|
||
| /** | ||
| * Prunes a node when it is collapsible. This overloaded | ||
| * version only considers the node occupancy for pruning, | ||
| * different intensities of child nodes are ignored. | ||
| * @return true if pruning was successful | ||
| */ | ||
| virtual bool pruneNode(IntensityOcTreeNode *node); | ||
|
|
||
| void updateInnerOccupancy(); | ||
|
|
||
| void computeUpdateKeys(const octomap::Pointcloud &scan, | ||
| const octomath::Vector3 &origin, | ||
| octomap::KeySet &free_cells, | ||
| octomap::KeySet &occupied_cells, | ||
| double maxrange = -1.0); | ||
|
|
||
| IntensityOcTreeNode *integrateNodeIntensity(const OcTreeKey &key, | ||
| double intensity); | ||
| IntensityOcTreeNode *integrateNodeIntensity(float x, float y, float z, | ||
| double intensity); | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| protected: | ||
| void updateInnerOccupancyRecurs(IntensityOcTreeNode *node, unsigned depth); | ||
|
|
||
| /** | ||
| * Static member object which ensures that this OcTree's prototype | ||
| * ends up in the classIDMapping only once. You need this as a | ||
| * static member in any derived octree class in order to read .ot | ||
| * files through the AbstractOcTree factory. You should also call | ||
| * ensureLinking() once from the constructor. | ||
| */ | ||
| class StaticMemberInitializer | ||
| { | ||
| public: | ||
| StaticMemberInitializer() | ||
| { | ||
| IntensityOcTree *tree = new IntensityOcTree(0.1); | ||
| tree->clearKeyRays(); | ||
| AbstractOcTree::registerTreeType(tree); | ||
| } | ||
| /** | ||
| * Dummy function to ensure that MSVC does not drop the | ||
| * StaticMemberInitializer, causing this tree failing to register. | ||
| * Needs to be called from the constructor of this octree. | ||
| */ | ||
| void ensureLinking() | ||
| { | ||
| } | ||
| }; | ||
|
|
||
| /// to ensure static initialization (only once) | ||
| static StaticMemberInitializer intensityOcTreeMemberInit; | ||
| }; | ||
|
|
||
| }// namespace octomap | ||
|
|
||
| #endif// OCTOMAP_INTENSITY_OCTREE_H | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| /* | ||
| * OctoMap - An Efficient Probabilistic 3D Mapping Framework Based on Octrees | ||
| * https://octomap.github.io/ | ||
| * | ||
| * Copyright (c) 2009-2013, K.M. Wurm and A. Hornung, University of Freiburg | ||
| * All rights reserved. | ||
| * License: New BSD | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. | ||
| * * Neither the name of the University of Freiburg nor the names of its | ||
| * contributors may be used to endorse or promote products derived from | ||
| * this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
| * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE | ||
| * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #include "octomap/IntensityOcTree.h" | ||
|
|
||
| namespace octomap | ||
| { | ||
| // Node implementation | ||
| std::istream &IntensityOcTreeNode::readData(std::istream &s) | ||
| { | ||
| s.read((char *) &value, sizeof(value));// occupancy | ||
| s.read(reinterpret_cast<char *>(&intensity), sizeof(intensity)); | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return s; | ||
| } | ||
|
|
||
| std::ostream &IntensityOcTreeNode::writeData(std::ostream &s) const | ||
| { | ||
| s.write((const char *) &value, sizeof(value));// occupancy | ||
| s.write(reinterpret_cast<const char *>(&intensity), sizeof(intensity)); | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return s; | ||
| } | ||
|
|
||
| double IntensityOcTreeNode::getAverageChildIntensity() const | ||
| { | ||
| double sum = 0.0; | ||
| unsigned cnt = 0; | ||
|
|
||
| if (children != NULL) | ||
| { | ||
| for (unsigned i = 0; i < 8; ++i) | ||
| { | ||
| IntensityOcTreeNode *child = | ||
| static_cast<IntensityOcTreeNode *>(children[i]); | ||
|
|
||
| if (child != NULL && child->isIntensitySet()) | ||
| { | ||
| sum += child->getIntensity(); | ||
| ++cnt; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| double average_intensity = cnt ? sum / cnt : intensity; | ||
| return average_intensity; | ||
viplix3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| inline void IntensityOcTreeNode::updateIntensityChildren() | ||
viplix3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| { | ||
| intensity = getAverageChildIntensity(); | ||
| } | ||
|
|
||
| // Tree implementation | ||
| IntensityOcTree::IntensityOcTree(double resolution) | ||
| : OccupancyOcTreeBase<IntensityOcTreeNode>(resolution) | ||
| { | ||
| intensityOcTreeMemberInit.ensureLinking(); | ||
| } | ||
|
|
||
|
|
||
| void IntensityOcTree::updateInnerOccupancy() | ||
| { | ||
| this->updateInnerOccupancyRecurs(this->root, 0); | ||
| } | ||
|
|
||
| void IntensityOcTree::updateInnerOccupancyRecurs(IntensityOcTreeNode *node, | ||
| unsigned depth) | ||
| { | ||
| if (nodeHasChildren(node)) | ||
| { | ||
| if (depth < this->tree_depth) | ||
| { | ||
| for (unsigned i = 0; i < 8; ++i) | ||
| { | ||
| if (nodeChildExists(node, i)) | ||
| updateInnerOccupancyRecurs(getNodeChild(node, i), | ||
| depth + 1); | ||
| } | ||
| } | ||
| node->updateOccupancyChildren(); | ||
| node->updateIntensityChildren(); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| void IntensityOcTree::computeUpdateKeys(const octomap::Pointcloud &scan, | ||
| const octomath::Vector3 &origin, | ||
| octomap::KeySet &free_cells, | ||
| octomap::KeySet &occupied_cells, | ||
| double maxrange) | ||
| { | ||
| // Delegates to base class | ||
| computeUpdate(scan, octomap::point3d(origin.x(), origin.y(), origin.z()), | ||
| free_cells, occupied_cells, maxrange); | ||
| } | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Node Pruning | ||
| bool IntensityOcTree::pruneNode(IntensityOcTreeNode *node) | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| if (!isNodeCollapsible(node)) | ||
| return false; | ||
|
|
||
| // set value to children's values (all assumed equal) | ||
| node->copyData(*(getNodeChild(node, 0))); | ||
|
|
||
| // update intensity | ||
| if (node->isIntensitySet()) | ||
| node->setIntensity(node->getAverageChildIntensity()); | ||
viplix3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| // delete children | ||
| for (unsigned int i = 0; i < 8; i++) | ||
| { | ||
| deleteNodeChild(node, i); | ||
| } | ||
| delete[] node->children; | ||
| node->children = NULL; | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
|
|
||
| // Integration | ||
| IntensityOcTreeNode * | ||
| IntensityOcTree::integrateNodeIntensity(const OcTreeKey &key, double intensity) | ||
| { | ||
| IntensityOcTreeNode *n = search(key); | ||
| if (n != 0) | ||
| { | ||
| if (n->isIntensitySet()) | ||
| { | ||
| double prev_intensity = n->getIntensity(); | ||
| double node_prob = n->getOccupancy(); | ||
|
|
||
| double new_intensity = (prev_intensity * node_prob + | ||
| intensity * (1.0 - node_prob)); | ||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| n->setIntensity(new_intensity); | ||
| } | ||
| else | ||
| { | ||
| n->setIntensity(intensity); | ||
| } | ||
| } | ||
| return n; | ||
| } | ||
|
|
||
| IntensityOcTreeNode *IntensityOcTree::integrateNodeIntensity(float x, float y, | ||
| float z, | ||
| double intensity) | ||
| { | ||
| OcTreeKey key; | ||
| if (!this->coordToKeyChecked(point3d(x, y, z), key)) | ||
| return NULL; | ||
| return integrateNodeIntensity(key, intensity); | ||
| } | ||
|
|
||
viplix3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }// namespace octomap | ||
viplix3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.