PoC - Trust all certs issued by trusted root authority - Do Not Merge #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pawelpabich I found this in our docs. Is the reason that configuring custom certificates isn't enough to facilitate MITM by configuring tentacle and server to trust the certs presented by the proxy, that the proxies generate new certificates often? |
|
Conversation has moved to https://octopusdeploy.slack.com/archives/C075APRMJP5/p1716981406294229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Some environments require all traffic to be decrypted and inspected by a centralized proxy. This is usually done by implementing MITM, where the proxy becomes a trusted Root Authority and the clients trust all certificates issued by it. Halibut security is based on certificate pinning, which breaks MITM.
This PoC proposes to support the first leg of MITM (halibut -> proxy) by adding an option to Halibut to allow it to trust any cert issued by a trusted root authority.
Note: Explore options to combine
IClientCertificateValidatorandITrustProvideras they seem to be doing the same thing, just at 2 different ends of the connection.