Allow overriding SSL configuration #697
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In Octopus Server we want to be able to control the supported protocols used by SSL. Currently Halibut enables TLS 1.0-1.3 to maximise compatibility. We would like to defer this configuration to the underlying Operating System where possible.
By allowing the SSL configuration to be overridden, we can transition between these two states in a controlled manner.
Results
DefaultSslConfigurationProvider
uses the underlying Operating System defaults.LegacySslConfigurationProvider
explicitly allows TLS 1.0-1.3, mirroring previous behaviour.Before
After
How to review this PR
Quality ✔️
Pre-requisites