Skip to content

Conversation

rhysparry
Copy link
Contributor

Background

In Octopus Server we want to be able to control the supported protocols used by SSL. Currently Halibut enables TLS 1.0-1.3 to maximise compatibility. We would like to defer this configuration to the underlying Operating System where possible.

By allowing the SSL configuration to be overridden, we can transition between these two states in a controlled manner.

Results

  • Changes default SSL protocols to be defined by the underlying Operating System
  • Allows overriding defined set of supported protocols. Two implementations include:
    • DefaultSslConfigurationProvider uses the underlying Operating System defaults.
    • LegacySslConfigurationProvider explicitly allows TLS 1.0-1.3, mirroring previous behaviour.

Before

  • TLS1.0-1.3 would be considered supported protocols. Underlying Operating System settings may explicitly make some of these options unavailable.

After

  • The default sbet of supported protocols is defined by the underlying Operating System
  • The set of protocols can be overridden if desired

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@rhysparry rhysparry requested a review from a team as a code owner October 14, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant