Skip to content

Commit

Permalink
Renamed filter to searchByVersion for clarity.
Browse files Browse the repository at this point in the history
  • Loading branch information
Rob Pearson committed Jul 11, 2017
1 parent 8fe7988 commit 716ed5b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
7 changes: 3 additions & 4 deletions source/Octopus.Client/Repositories/Async/ProjectRepository.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using System;
using System.IO;
using System.Collections.Generic;
using System.Threading.Tasks;
Expand All @@ -10,7 +9,7 @@ namespace Octopus.Client.Repositories.Async

public interface IProjectRepository : IFindByName<ProjectResource>, IGet<ProjectResource>, ICreate<ProjectResource>, IModify<ProjectResource>, IDelete<ProjectResource>, IGetAll<ProjectResource>
{
Task<ResourceCollection<ReleaseResource>> GetReleases(ProjectResource project, int skip = 0, int? take = null, string filter = null);
Task<ResourceCollection<ReleaseResource>> GetReleases(ProjectResource project, int skip = 0, int? take = null, string searchByVersion = null);
Task<IReadOnlyList<ReleaseResource>> GetAllReleases(ProjectResource project);
Task<ReleaseResource> GetReleaseByVersion(ProjectResource project, string version);
Task<ResourceCollection<ChannelResource>> GetChannels(ProjectResource project);
Expand All @@ -28,9 +27,9 @@ public ProjectRepository(IOctopusAsyncClient client)
{
}

public Task<ResourceCollection<ReleaseResource>> GetReleases(ProjectResource project, int skip = 0, int? take = null, string filter = null)
public Task<ResourceCollection<ReleaseResource>> GetReleases(ProjectResource project, int skip = 0, int? take = null, string searchByVersion = null)
{
return Client.List<ReleaseResource>(project.Link("Releases"), new { skip, take, filter });
return Client.List<ReleaseResource>(project.Link("Releases"), new { skip, take, searchByVersion });
}

public Task<IReadOnlyList<ReleaseResource>> GetAllReleases(ProjectResource project)
Expand Down
7 changes: 3 additions & 4 deletions source/Octopus.Client/Repositories/ProjectRepository.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using System;
using System.Collections.Generic;
using System.IO;
using Octopus.Client.Editors;
Expand All @@ -8,7 +7,7 @@ namespace Octopus.Client.Repositories
{
public interface IProjectRepository : IFindByName<ProjectResource>, IGet<ProjectResource>, ICreate<ProjectResource>, IModify<ProjectResource>, IDelete<ProjectResource>, IGetAll<ProjectResource>
{
ResourceCollection<ReleaseResource> GetReleases(ProjectResource project, int skip = 0, int? take = null, string filter = null);
ResourceCollection<ReleaseResource> GetReleases(ProjectResource project, int skip = 0, int? take = null, string searchByVersion = null);
IReadOnlyList<ReleaseResource> GetAllReleases(ProjectResource project);
ReleaseResource GetReleaseByVersion(ProjectResource project, string version);
ResourceCollection<ChannelResource> GetChannels(ProjectResource project);
Expand All @@ -26,9 +25,9 @@ public ProjectRepository(IOctopusClient client)
{
}

public ResourceCollection<ReleaseResource> GetReleases(ProjectResource project, int skip = 0, int? take = null, string filter = null)
public ResourceCollection<ReleaseResource> GetReleases(ProjectResource project, int skip = 0, int? take = null, string searchByVersion = null)
{
return Client.List<ReleaseResource>(project.Link("Releases"), new { skip, take, filter });
return Client.List<ReleaseResource>(project.Link("Releases"), new { skip, take, searchByVersion });
}

public IReadOnlyList<ReleaseResource> GetAllReleases(ProjectResource project)
Expand Down

0 comments on commit 716ed5b

Please sign in to comment.