Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OctopusRepositoryExtensions with methods that reuse RootResource #869

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Replace OctopusRepositoryExtensions with methods that reuse RootResource

f000765
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Replace OctopusRepositoryExtensions with methods that reuse RootResource #869

Replace OctopusRepositoryExtensions with methods that reuse RootResource
f000765
Select commit
Loading
Failed to load commit list.
GitHub Actions / Windows .NET 6.0 E2E test results succeeded Aug 15, 2024 in 0s

29 passed, 0 failed and 0 skipped

Tests passed successfully

✅ ./TestResults/Win-E2E_net6.0_20240815000401.trx

29 tests were completed in 1s with 29 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Octopus.Client.E2ETests.InlinedDependenciesFixture 7✅ 111ms
Octopus.Client.E2ETests.NuSpecDependenciesFixture 20✅ 5ms
Octopus.Client.E2ETests.OctopusClientsCanBeMockedFixture 2✅ 158ms

✅ Octopus.Client.E2ETests.InlinedDependenciesFixture

✅ HasInlinedDependency("Newtonsoft.Json","Newtonsoft.Json.JsonConvert",Internal)
✅ HasInlinedDependency("Octodiff","Octodiff.Core.DeltaBuilder",Internal)
✅ HasInlinedDependency("Octopus.Server.MessageContracts.Base.HttpRoutes","Octopus.Server.MessageContracts.Base.HttpRoutes.HttpRouteTemplateAttribute",Public)
✅ HasInlinedDependency("Octopus.Server.MessageContracts.Base","Octopus.Server.MessageContracts.Base.ICommand`2",Public)
✅ HasInlinedDependency("Octopus.TinyTypes.Json","Octopus.TinyTypes.Json.TinyTypeJsonConverter",Internal)
✅ HasInlinedDependency("Octopus.TinyTypes.TypeConverters","Octopus.TinyTypes.TypeConverters.TinyTypeConverter`1",Internal)
✅ HasInlinedDependency("Octopus.TinyTypes","Octopus.TinyTypes.TinyType`1",Internal)

✅ Octopus.Client.E2ETests.NuSpecDependenciesFixture

✅ DependencyVersionShouldBeSameVersionAsCsProj(".NETStandard2.0","Microsoft.CSharp")
✅ DependencyVersionShouldBeSameVersionAsCsProj(".NETStandard2.0","System.ComponentModel.Annotations")
✅ NuSpecFileShouldHave3FrameworkAssembliesForNetFramework462
✅ NuSpecFileShouldHave3FrameworkAssembliesForNetFramework48
✅ NuSpecFileShouldHaveADependencyGroupForEachTargetFramework
✅ NuSpecFileShouldHaveADependencyNode
✅ NuSpecFileShouldHaveAFrameworkAssembliesNode
✅ NuSpecFileShouldHaveCorrectDependencyCounts(".NETFramework4.6.2",[])
✅ NuSpecFileShouldHaveCorrectDependencyCounts(".NETStandard2.0",["Microsoft.CSharp", "System.ComponentModel.Annotations"])
✅ NuSpecFileShouldHaveCorrectDependencyGroups(".NETFramework4.6.2",[])
✅ NuSpecFileShouldHaveCorrectDependencyGroups(".NETStandard2.0",["Microsoft.CSharp", "System.ComponentModel.Annotations"])
✅ NuSpecFileShouldHaveExpectedDependency(".NETStandard2.0","Microsoft.CSharp")
✅ NuSpecFileShouldHaveExpectedDependency(".NETStandard2.0","System.ComponentModel.Annotations")
✅ NuSpecFileShouldHaveSystemComponentModelDataAnnotationsFrameworkAssemblyForNetFramework462("System.ComponentModel.DataAnnotations")
✅ NuSpecFileShouldHaveSystemComponentModelDataAnnotationsFrameworkAssemblyForNetFramework462("System.Net.Http")
✅ NuSpecFileShouldHaveSystemComponentModelDataAnnotationsFrameworkAssemblyForNetFramework462("System.Numerics")
✅ NuSpecFileShouldHaveSystemComponentModelDataAnnotationsFrameworkAssemblyForNetFramework48("System.ComponentModel.DataAnnotations")
✅ NuSpecFileShouldHaveSystemComponentModelDataAnnotationsFrameworkAssemblyForNetFramework48("System.Net.Http")
✅ NuSpecFileShouldHaveSystemComponentModelDataAnnotationsFrameworkAssemblyForNetFramework48("System.Numerics")
✅ NuSpecFileShouldOnlyHaveFrameworkAssembliesForNetFramework

✅ Octopus.Client.E2ETests.OctopusClientsCanBeMockedFixture

✅ WeShouldBeAbleToCreateAMockAsyncClient
✅ WeShouldBeAbleToCreateAMockClient