Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When downloading the .NET SDK during the build it would fail if the system did not enable TLS 1.2 by default. This is generally the case for older Windows versions.
This PR aims to move the modification into the build bootstrapper. This will mean that upstream fixes to the dotnet installer will be available immediately.
Why not TLS 1.3?
Prior to .NET Framework 4.8, TLS 1.3 was not available. Supporting TLS 1.3 would require special-casing these older versions.
Results
dotnet-install.ps1
filedotnet-install.ps1
usage inbuild.ps1
build.ps1
to ensure TLS1.2 is enabled when the download script attempts to download the .NET SDK.How to review this PR
Quality ✔️
Pre-requisites