Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom dotnet-install.ps1 #1066

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

rhysparry
Copy link
Contributor

Background

When downloading the .NET SDK during the build it would fail if the system did not enable TLS 1.2 by default. This is generally the case for older Windows versions.

This PR aims to move the modification into the build bootstrapper. This will mean that upstream fixes to the dotnet installer will be available immediately.

Why not TLS 1.3?

Prior to .NET Framework 4.8, TLS 1.3 was not available. Supporting TLS 1.3 would require special-casing these older versions.

Results

  • Removes the custom dotnet-install.ps1 file
  • Restores dotnet-install.ps1 usage in build.ps1
  • Adds customization to build.ps1 to ensure TLS1.2 is enabled when the download script attempts to download the .NET SDK.

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@rhysparry rhysparry marked this pull request as ready for review February 17, 2025 23:15
@rhysparry rhysparry requested a review from a team as a code owner February 17, 2025 23:15
@rhysparry rhysparry merged commit ea2aeed into main Feb 18, 2025
51 of 52 checks passed
@rhysparry rhysparry deleted the sast/rhysparry/remove-custom-dotnet-install branch February 18, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants