Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the setup fixture to tell users it is slow to run and clicking it will show logs #1068

Merged

Conversation

LukeButters
Copy link
Contributor

Background

Some devs are left wondering what on earth is happening the first time Integration tests run locally.

What happens is we download potentially GBs of data to download tentacle for testing.

The Fixture which does that is renamed to hint it could be slow and how to view progress:

image

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@LukeButters LukeButters requested a review from a team as a code owner February 21, 2025 00:03
Copy link
Contributor

@rhysparry rhysparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Do it.

@LukeButters LukeButters enabled auto-merge (squash) February 21, 2025 00:57
@LukeButters LukeButters merged commit 1c17e98 into main Feb 21, 2025
51 of 52 checks passed
@LukeButters LukeButters deleted the luke/improve-logging-when-downloading-IT-tentacles branch February 21, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants