Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running Integration Tests on OSX #1069

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Fix running Integration Tests on OSX #1069

merged 1 commit into from
Feb 23, 2025
+7 −8

Conversation

LukeButters
Copy link
Contributor

Background

  • Fixing the tar command where the path contains spaces.
  • Fixes downloading older tentacles. The issue was it was trying to use net8 versions of old version of tentacle which did not exist.

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@LukeButters LukeButters requested a review from a team as a code owner February 21, 2025 00:44
@LukeButters LukeButters changed the title Fix running IT on OSX Fix running Integration Tests on OSX Feb 21, 2025
@LukeButters LukeButters enabled auto-merge (squash) February 21, 2025 00:57
rhysparry
rhysparry approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@rhysparry rhysparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@LukeButters LukeButters force-pushed the luke/fix-running-IT-on-mac branch from a940f32 to d4a9729 Compare February 23, 2025 21:32
@LukeButters LukeButters merged commit dd9e67a into main Feb 23, 2025
51 of 52 checks passed
@LukeButters LukeButters deleted the luke/fix-running-IT-on-mac branch February 23, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhysparry rhysparry rhysparry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeButters @rhysparry