-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Spelling #204
base: main
Are you sure you want to change the base?
chore: Spelling #204
Changes from all commits
cde05a1
b1f18a1
334a6ab
cdfdc01
fa51534
1cc64d4
ff5d503
47694de
886f9d8
d3b025a
fb8cd0c
b5d164e
7b80631
ec4dd4e
34dbece
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ func NewSSHKeyAccount(name string, username string, privateKeyFile *core.Sensiti | |
return &account, nil | ||
} | ||
|
||
// SetPrivateKeyPassphrase sets the private key [assphrase of this SSH key pair account. | ||
// SetPrivateKeyPassphrase sets the private key passphrase of this SSH key pair account. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was amusing |
||
func (s *SSHKeyAccount) SetPrivateKeyPassphrase(privateKeyPassphrase *core.SensitiveValue) { | ||
s.PrivateKeyPassphrase = privateKeyPassphrase | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ type EventsQuery struct { | |
FromAutoID string `uri:"fromAutoId,omitempty" url:"fromAutoId,omitempty"` | ||
IDs []string `uri:"ids,omitempty" url:"ids,omitempty"` | ||
IncludeSystem bool `uri:"includeSystem,omitempty" url:"includeSystem,omitempty"` | ||
Internal string `uri:"interal,omitempty" url:"interal,omitempty"` | ||
Internal string `uri:"internal,omitempty" url:"internal,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes like this are scary, as it's an API of sorts... |
||
Name string `uri:"name,omitempty" url:"name,omitempty"` | ||
PartialName string `uri:"partialName,omitempty" url:"partialName,omitempty"` | ||
ProjectGroups []string `uri:"projectGroups,omitempty" url:"projectGroups,omitempty"` | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,5 +30,5 @@ func NewInterruption() *Interruption { | |
} | ||
} | ||
|
||
const ManualInterverventionApprove = "Proceed" | ||
const ManualInterventionApprove = "Proceed" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably an API of sorts and thus probably can't be done either. |
||
const ManualInterventionDecline = "Abort" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,7 +75,7 @@ func (s *SSHEndpoint) GetProxyID() string { | |
func (s *SSHEndpoint) MarshalJSON() ([]byte, error) { | ||
sshEndpoint := struct { | ||
AccountID string `json:"AccountId,omitempty"` | ||
ComunicationStyle string `json:"CommunicationStyle" validate:"required,eq=Ssh"` | ||
CommunicationStyle string `json:"CommunicationStyle" validate:"required,eq=Ssh"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be an API too... |
||
DotNetCorePlatform string | ||
Fingerprint string | ||
Host string | ||
|
@@ -85,7 +85,7 @@ func (s *SSHEndpoint) MarshalJSON() ([]byte, error) { | |
resources.Resource | ||
}{ | ||
AccountID: s.AccountID, | ||
ComunicationStyle: s.CommunicationStyle, | ||
CommunicationStyle: s.CommunicationStyle, | ||
DotNetCorePlatform: s.DotNetCorePlatform, | ||
Fingerprint: s.Fingerprint, | ||
Host: s.Host, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,7 +185,7 @@ func parseTerm(term string) (result templateTerm, err error) { | |
err = errors.New("not a valid name: " + result.name) | ||
} | ||
if result.explode && result.truncate > 0 { | ||
err = errors.New("both explode and prefix modifers on same term") | ||
err = errors.New("both explode and prefix modifiers on same term") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm hoping nothing cares about the spelling of error messages. |
||
} | ||
return result, err | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes probably can't be made, but they're unfortunate, and I'm using this PR to call them out...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This device is being used by a 9 yr old kid right now. I don't want to be mistreated again as what happened before.
No cla signet yet.