Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OTEL metrics export #339

Merged
merged 15 commits into from
Nov 28, 2024
Merged

Conversation

matt-richardson
Copy link
Contributor

@matt-richardson matt-richardson commented Nov 26, 2024

Background

We're seeing missing spans, which leads me to think (thanks ChatGPT!) that the BatchSpanProcessor is getting overloaded, and dropping spans.

[sc-96078]

Results

This PR adds support for sending metrics (to honeycomb only for now) to help investigate this issue

image

image

How to review this PR

Pre-requisites

  • I have considered informing or consulting the right people
  • I have considered appropriate testing for my change.

So we can diagnose dropped spans
@matt-richardson matt-richardson self-assigned this Nov 26, 2024
@matt-richardson matt-richardson marked this pull request as ready for review November 28, 2024 01:29
@matt-richardson matt-richardson requested a review from a team as a code owner November 28, 2024 01:29
Copy link

@wlthomson wlthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me 👍 .

@matt-richardson matt-richardson merged commit 5490846 into main Nov 28, 2024
3 checks passed
@matt-richardson matt-richardson deleted the mattr/rsb/otel-metrics branch November 28, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants