Add MaxTxSize check to ValidateExpressLaneTx() #4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
KolbyML
force-pushed
the
NIT-4157
branch
3 times, most recently
from
4559510 to
1715b85
Compare
rauljordan
reviewed
Dec 4, 2025
cmd/el-proxy/config.go
Outdated
| } | ||
|
|
||
| func (c *ExpressLaneProxyConfig) Validate() error { | ||
| if c.MaxTxDataSize > arbostypes.MaxL2MessageSize-50000 { |
Contributor
There was a problem hiding this comment.
The 50k is a magic number and will have issues if we specify a config smaller than it, maybe we can either abstract it as constant or move it to the other side of the inequality? Also add the values to the error format string
Member
Author
There was a problem hiding this comment.
I attempted to resolve the concern, let me know what you think
Member
There was a problem hiding this comment.
I think the way you fixed it looks good, but I'd love to have a short comment above the constant why do we use 50'000 - I have no idea what this number represents actually 😅
Member
Author
There was a problem hiding this comment.
I have no idea as well, I added a comment with the details of when this change was added
pmikolajczyk41
previously approved these changes
Dec 5, 2025
Member
pmikolajczyk41
left a comment
pmikolajczyk41
left a comment
There was a problem hiding this comment.
Although I have some minor questions, I'm happy with the current code, so an approval from my side ✅
Contributor
ganeshvanahalli
left a comment
ganeshvanahalli
left a comment
There was a problem hiding this comment.
We do already have MaxTxSize check in the sequencer right?
nitro/execution/gethexec/sequencer.go
Lines 1295 to 1299 in 6837a8f
Member
Author
We do check for this in the sequencer, we should fail transactions before they reach the sequencer when possible. |
pmikolajczyk41
previously approved these changes
Dec 5, 2025
rauljordan
previously approved these changes
Dec 5, 2025
ganeshvanahalli
previously approved these changes
Dec 6, 2025
KolbyML
dismissed stale reviews from ganeshvanahalli, rauljordan, and pmikolajczyk41
via
d4cb495
Member
Author
|
@joshuacolvin0 helped show me Transaction.Size() and len(MarshalBinary) are the same thing. I updated the sequencer to use .Size(), along with the validation check I added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves NIT-4157
The premise is we should check if a transaction is valid, before we send it when possible.
We already check the MaxTxDataSize in
ValidateTransaction(), so we should do it forValidateExpressLaneTx()as well.I am using uint64, as I don't think we should use
intas itThe sequencer takes length of
msg.Transaction.MarshalBinary()for its internal size check, I am surprised it doesn't use.Size(), that is why I must do the same here.