Skip to content

drop unused validator RPC jwt secret state #16063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

drop unused validator RPC jwt secret state #16063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23ea3a1
Update server.go
Doryu001 Nov 26, 2025
944726b
Update auth_token.go
Doryu001 Nov 26, 2025
0897ece
Update auth_token_test.go
Doryu001 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions validator/rpc/auth_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,10 @@ func (s *Server) initializeAuthToken() error {
log.Error(err)
}
}()
secret, token, err := readAuthTokenFile(f)
_, token, err := readAuthTokenFile(f)
if err != nil {
return err
}
s.jwtSecret = secret
s.authToken = token
return nil
}
Expand Down
2 changes: 0 additions & 2 deletions validator/rpc/auth_token_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/OffchainLabs/prysm/v7/api"
"github.com/OffchainLabs/prysm/v7/io/file"
"github.com/OffchainLabs/prysm/v7/testing/require"
"github.com/ethereum/go-ethereum/common/hexutil"
"github.com/golang-jwt/jwt/v4"
logTest "github.com/sirupsen/logrus/hooks/test"
"google.golang.org/grpc"
Expand Down Expand Up @@ -125,7 +124,6 @@ func TestServer_LegacyTokensStillWork(t *testing.T) {
err = srv.initializeAuthToken()
require.NoError(t, err)

require.Equal(t, hexutil.Encode(srv.jwtSecret), "0xb5bbbaf533b625a93741978857f13d7adeca58445a1fb00ecf3373420b92776c")
require.Equal(t, srv.authToken, "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.e30.MxwOozSH-TLbW_XKepjyYDHm2IT8Ki0tD3AHuajfNMg")

f, err := os.Open(filepath.Clean(srv.authTokenPath))
Expand Down
2 changes: 0 additions & 2 deletions validator/rpc/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ type Server struct {
startFailure error
ctx context.Context
walletDir string
jwtSecret []byte
grpcHeaders []string
}

Expand Down Expand Up @@ -219,7 +218,6 @@ func (s *Server) InitializeRoutes() error {
s.router.HandleFunc("GET "+api.WebUrlPrefix+"wallet", s.WalletConfig)
s.router.HandleFunc("POST "+api.WebUrlPrefix+"wallet/create", s.CreateWallet)
s.router.HandleFunc("POST "+api.WebUrlPrefix+"wallet/keystores/validate", s.ValidateKeystores)
s.router.HandleFunc("POST "+api.WebUrlPrefix+"wallet/recover", s.RecoverWallet)
// slashing protection endpoints
s.router.HandleFunc("GET "+api.WebUrlPrefix+"slashing-protection/export", s.ExportSlashingProtection)
s.router.HandleFunc("POST "+api.WebUrlPrefix+"slashing-protection/import", s.ImportSlashingProtection)
Expand Down
Loading